Files: 
CommentFileSizeAuthor
#5 views-method_allow_advanced_render-2002356-05.patch2.49 KBSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 55,933 pass(es).
[ View ]
#2 2002356-2-rename_allowAdvancedRender.patch2.47 KBGung Wang
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Gung Wang’s picture

Assigned:Unassigned» Gung Wang

I take it.

Gung Wang’s picture

Status:Active» Needs review
StatusFileSize
new2.47 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Status:Needs review» Needs work

The last submitted patch, 2002356-2-rename_allowAdvancedRender.patch, failed testing.

aspilicious’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -89,7 +89,7 @@ public function init(ViewExecutable $view, DisplayPluginBase $display, array &$o
+  function allowAdvancedRender() {

Should be protected function ...

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/PrerenderList.phpundefined
@@ -114,7 +114,7 @@ function get_items($values) {
+  function allowAdvancedRender() {

Same

SpartyDan’s picture

Status:Needs work» Needs review
StatusFileSize
new2.49 KB
PASSED: [[SimpleTest]]: [MySQL] 55,933 pass(es).
[ View ]

added protected function and re-rolled

elvis2’s picture

Status:Needs review» Reviewed & tested by the community

Looks good.

Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed e55477f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.