Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In template.php the __DIR__ constant is used but it was only introduced in PHP 5.3, its a one-off usage and I think a lot of people would appreciate keeping the required PHP version the same as core for D7 :)
Comment | File | Size | Author |
---|---|---|---|
#1 | zurb-foundation-2001046-dont-require-php53-1.patch | 550 bytes | alexweber |
Comments
Comment #1
alexweber CreditAttribution: alexweber commentedComment #2
alexweber CreditAttribution: alexweber commentedComment #3
kevinquillen CreditAttribution: kevinquillen commentedPatch looks good, tested, theme works. Sorry to cut off any PHP 5.2.x folk.
Comment #4
alexweber CreditAttribution: alexweber commentedYay!
Comment #5
chrisjlee CreditAttribution: chrisjlee commentedFor the reference committed here by Kevin: http://drupalcode.org/project/zurb-foundation.git/commit/d2f0f21
Needs backport to other branches:
- 8.x-1.x
- 7.x-4.x
- 7.x-1.x
Comment #6
chrisjlee CreditAttribution: chrisjlee commentedComment #7
alexweber CreditAttribution: alexweber commented@chrisjlee, we're actually all set! :)
The patch in #1 applies cleanly on 7.x-1.x so it's just a matter of committing it and Drupal 8 requires PHP 5.3 anyway so nothing needed there.
Comment #8
kevinquillen CreditAttribution: kevinquillen commentedMeant to follow up with that - I was trying to find the D8 requirements but I am pretty confident it is 5.3.x.
Comment #9
chrisjlee CreditAttribution: chrisjlee commented@alexweber / @kevinquillen my mistake! Sounds good to me.
Comment #10
alexweber CreditAttribution: alexweber commentedWoohoo!
PS - Kevin: http://drupal.org/requirements
Comment #11
alexweber CreditAttribution: alexweber commentedCommitted in 7.x-1.x-dev: http://drupalcode.org/project/zurb-foundation.git/commit/c8bd1dd