In template.php the __DIR__ constant is used but it was only introduced in PHP 5.3, its a one-off usage and I think a lot of people would appreciate keeping the required PHP version the same as core for D7 :)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexweber’s picture

Status: Active » Needs review
FileSize
550 bytes
alexweber’s picture

Title: Don't rely on PHP 5.3 » Don't require PHP 5.3
kevinquillen’s picture

Status: Needs review » Fixed

Patch looks good, tested, theme works. Sorry to cut off any PHP 5.2.x folk.

alexweber’s picture

Yay!

chrisjlee’s picture

For the reference committed here by Kevin: http://drupalcode.org/project/zurb-foundation.git/commit/d2f0f21

Needs backport to other branches:

- 8.x-1.x
- 7.x-4.x
- 7.x-1.x

chrisjlee’s picture

Status: Fixed » Needs work
alexweber’s picture

Version: 7.x-4.x-dev » 7.x-1.x-dev
Status: Needs work » Needs review

@chrisjlee, we're actually all set! :)

The patch in #1 applies cleanly on 7.x-1.x so it's just a matter of committing it and Drupal 8 requires PHP 5.3 anyway so nothing needed there.

kevinquillen’s picture

Meant to follow up with that - I was trying to find the D8 requirements but I am pretty confident it is 5.3.x.

chrisjlee’s picture

@alexweber / @kevinquillen my mistake! Sounds good to me.

alexweber’s picture

Woohoo!

PS - Kevin: http://drupal.org/requirements

alexweber’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.