Section privacy doesn't work in private spaces [#1995946]

Since node grants are or-ed, the node grant's for private groups take presidence

Also, seems to be some bugs with determining spaces/sections (array_merge is not recursive so won't merge array('node' => array(x)) and array('node' => array(y)) as array('node' => array(x, y)))

Comments

Comment #1

hefox CreditAttribution: hefox commented 16 May 2013 at 05:05

Status:

Active

» Fixed

Comment #2

mpotter CreditAttribution: mpotter commented 16 May 2013 at 13:14

I'll take a look at the fix, but this definitely confuses me a bit. In my understanding of the node grant system, you need a grant for *each* realm. Since OG and OA use different realms, the fact that the OG grant is satisfied should not cause the OA grant to always succeed.

Comment #3

hefox CreditAttribution: hefox commented 16 May 2013 at 14:17

Grants are or-ed togeather. If you have a grant that matches one for that node, you got access to that node. Private og items are given a grant related to that, and users with access to have the matching grant, thus allowing users to see private og content. So in case of private section, the node has both the og grant and the sections grant, so anyone with the og grant could see it. By upping the 'priority' property, the og grant for the node is rejected and only the section grant is valid for that node, so user must have that grant to see it.