The changes made in #1941080: Menu translation on node form is broken causes a bunch of notices on the node edit form, when using translation sets for menu translation.

Notice: Undefined index: link_title in menu_form_node_form_alter() (line 645 of \modules\menu\menu.module).
Notice: Undefined index: mlid in menu_form_node_form_alter() (line 657 of \modules\menu\menu.module).

Patch coming soon.

Files: 
CommentFileSizeAuthor
#2 et-menu-notices-1992588-2.patch1.37 KBbforchhammer
PASSED: [[SimpleTest]]: [MySQL] 681 pass(es). View
#1 et-menu-notices-1992588-1.patch767 bytesbforchhammer
PASSED: [[SimpleTest]]: [MySQL] 681 pass(es). View

Comments

bforchhammer’s picture

Status: Active » Needs review
FileSize
767 bytes
PASSED: [[SimpleTest]]: [MySQL] 681 pass(es). View

This should do it.

(Basically, we should only update $node->menu if it actually contains a menu item; currently code was also updating it when it was actually NULL).

bforchhammer’s picture

FileSize
1.37 KB
PASSED: [[SimpleTest]]: [MySQL] 681 pass(es). View

Here's another notice:

Notice: Undefined index: title in entity_translation_i18n_menu_node_menu_item_translate() (line 275 of \sites\all\modules\entity_translation\entity_translation_i18n_menu\entity_translation_i18n_menu.module).

This one appears when you try to localize a menu item which doesn't have a description set in the original language.

bforchhammer’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 3242b20 on 7.x-1.x, factory, et-fc, revisions by bforchhammer:
    Issue #1992588 by bforchhammer: Fixed PHP notices on node page (menu-...

  • Commit 3242b20 on 7.x-1.x, factory, et-fc, revisions, workbench by bforchhammer:
    Issue #1992588 by bforchhammer: Fixed PHP notices on node page (menu-...