Remove 'module' from block plugin configuration

$plugin_definition contains a "provider" key and a "module" key. Are they ever different? Maybe we could just use the provider key instead?

@tim.plunkett++ It is fixed in #2065721: Add a dedicated @Block plugin annotation

I don't thinking actually fixed it, I'll post a patch showing what I mean.

In all fairness the title of the issue is confusing. I realized that after reading the original comment by @catch.

The 'module' needs to be stored due to how BlockPluginBag handles exceptions for disabled modules.
Postponing on #1199946: Disabled modules are broken beyond repair so the "disable" functionality needs to be removed

This is what I meant.

Well yeah, I guess that would be a problem :)

Perfect!

#2158003: Remove Block Cache API in favor of blocks returning #cache with cache tags moved some code around, but nothing changed here.

Can we turn off the auto retest until the known bot issues are resolved?

block-provider-1991442-11.patch no longer applies.

error: patch failed: core/modules/views/tests/Drupal/views/Tests/Plugin/Block/ViewsBlockTest.php:125
error: core/modules/views/tests/Drupal/views/Tests/Plugin/Block/ViewsBlockTest.php: patch does not apply

Re-roll.

Committed 41b6df5 and pushed to 8.x. Thanks!

Fixed whitespace errors on commit

diff --git a/core/modules/views/tests/Drupal/views/Tests/Plugin/Block/ViewsBlockTest.php b/core/modules/views/tests/Drupal/views/Tests/Plugin/Block/ViewsBlockTest.php
index 135a5b3..eb46cb3 100644
--- a/core/modules/views/tests/Drupal/views/Tests/Plugin/Block/ViewsBlockTest.php
+++ b/core/modules/views/tests/Drupal/views/Tests/Plugin/Block/ViewsBlockTest.php
@@ -128,7 +128,7 @@ public function testBuild() {
 
     $definition['provider'] = 'views';
     $plugin = new ViewsBlock($config, $block_id, $definition, $this->executableFactory, $this->storage, $this->account);
-    
+
     $this->assertEquals($build, $plugin->build());
   }
 
@@ -150,7 +150,7 @@ public function testBuildFailed() {
 
     $definition['provider'] = 'views';
     $plugin = new ViewsBlock($config, $block_id, $definition, $this->executableFactory, $this->storage, $this->account);
-    
+
     $this->assertEquals(array(), $plugin->build());
   }

No idea how that got in there, thanks.