Comments

pgillis’s picture

Status:Active» Needs review
StatusFileSize
new5.02 KB
pgillis’s picture

Needed to make more resilient to the callers.

pgillis’s picture

Cleaned up patch a bit. I realized some of the records weren't needed now that the Revisioning module has been updated.

shenzhuxi’s picture

I add module_exists('revisioning') checking.
Please test it.

pgillis’s picture

Hi,

Thanks for looking at this. If I understand what you were intending to do, shouldn't we also move the 'publish revisions of own " . $info->type . " content' permissions under the module_exists conditional?

pgillis’s picture

The hook signature was updated in revisioning module, so the last two parameters are no longer passed in.

pgillis’s picture

Updated patch, missed reference to $account after signature change.

pgillis’s picture

Status:Needs review» Closed (won't fix)

I've realized that this use case may be more specific than you want to include in your module. That is fine, I can implement these two hooks in my own module and just use what you already have released for og_moderation for the functionality it provides. Thanks...

shenzhuxi’s picture

Status:Closed (won't fix)» Fixed

committed

Please test the latest dev carefully, because I committed 3 patches at the same time.

I'm sorry I was in vacation for one month and didn't pay attention to the project.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

pgillis’s picture

Status:Closed (fixed)» Needs review
StatusFileSize
new1.41 KB

Hi, sorry for the late response! I had moved to implementing in local module because of how often the code would change with changes to other modules. I will open a separate request about integration with the node_clone module. That said, I ran into a few problems since my previous patch and have updated here.

Long story short, if you think this functionality belongs here, I am fine with that and will continue to supply patches where I think something is wrong. If not, I understand, and can maintain this hook in a separate module. Does that make sense? Thanks again for your help!

pgillis’s picture

Status:Needs review» Fixed

Committed code to 7.x-2.x branch.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.