I will submit a patch that implements og_moderation handling revisioning permissions. This patch depends on code that is in DEV branch of revisioning. It was added just after the last build was released.

CommentFileSizeAuthor
#11 og_moderation-publishing_permissions-1991066-11.patch1.41 KBpgillis
#7 og_moderation-publishing_permissions-1991066-7.patch3.5 KBpgillis
#6 og_moderation-publishing_permissions-1991066-6.patch3.51 KBpgillis
#5 og_moderation-publishing_permissions-1991066-5.patch3.57 KBpgillis
#4 og_moderation-publishing_permissions-1991066-4.patch3.9 KBshenzhuxi
#3 og_moderation-publishing_permissions-1991066-3.patch3.86 KBpgillis
#2 og_moderation-publishing_permissions-1991066-2.patch5.02 KBpgillis
#1 og_moderation-publishing_permissions-1991066-1.patch5.02 KBpgillis
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pgillis’s picture

pgillis CreditAttribution: pgillis commented
Status: Active » Needs review
FileSize
og_moderation-publishing_permissions-1991066-1.patch5.02 KB
pgillis’s picture

pgillis CreditAttribution: pgillis commented
FileSize
og_moderation-publishing_permissions-1991066-2.patch5.02 KB

Needed to make more resilient to the callers.

pgillis’s picture

pgillis CreditAttribution: pgillis commented
FileSize
og_moderation-publishing_permissions-1991066-3.patch3.86 KB

Cleaned up patch a bit. I realized some of the records weren't needed now that the Revisioning module has been updated.

shenzhuxi’s picture

shenzhuxi CreditAttribution: shenzhuxi commented
FileSize
og_moderation-publishing_permissions-1991066-4.patch3.9 KB

I add module_exists('revisioning') checking.
Please test it.

pgillis’s picture

pgillis CreditAttribution: pgillis commented
FileSize
og_moderation-publishing_permissions-1991066-5.patch3.57 KB

Hi,

Thanks for looking at this. If I understand what you were intending to do, shouldn't we also move the 'publish revisions of own " . $info->type . " content' permissions under the module_exists conditional?

pgillis’s picture

pgillis CreditAttribution: pgillis commented
FileSize
og_moderation-publishing_permissions-1991066-6.patch3.51 KB

The hook signature was updated in revisioning module, so the last two parameters are no longer passed in.

pgillis’s picture

pgillis CreditAttribution: pgillis commented
FileSize
og_moderation-publishing_permissions-1991066-7.patch3.5 KB

Updated patch, missed reference to $account after signature change.

pgillis’s picture

pgillis CreditAttribution: pgillis commented
Status: Needs review » Closed (won't fix)

I've realized that this use case may be more specific than you want to include in your module. That is fine, I can implement these two hooks in my own module and just use what you already have released for og_moderation for the functionality it provides. Thanks...

shenzhuxi’s picture

shenzhuxi CreditAttribution: shenzhuxi commented
Status: Closed (won't fix) » Fixed

committed

Please test the latest dev carefully, because I committed 3 patches at the same time.

I'm sorry I was in vacation for one month and didn't pay attention to the project.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

pgillis’s picture

pgillis CreditAttribution: pgillis commented
Status: Closed (fixed) » Needs review
FileSize
og_moderation-publishing_permissions-1991066-11.patch1.41 KB

Hi, sorry for the late response! I had moved to implementing in local module because of how often the code would change with changes to other modules. I will open a separate request about integration with the node_clone module. That said, I ran into a few problems since my previous patch and have updated here.

Long story short, if you think this functionality belongs here, I am fine with that and will continue to supply patches where I think something is wrong. If not, I understand, and can maintain this hook in a separate module. Does that make sense? Thanks again for your help!

pgillis’s picture

pgillis CreditAttribution: pgillis commented
Status: Needs review » Fixed

Committed code to 7.x-2.x branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.