Patch upcoming

Files: 
CommentFileSizeAuthor
#10 1989996-10.patch1.43 KBswentel
PASSED: [[SimpleTest]]: [MySQL] 56,026 pass(es). View
#10 interdiff.txt730 bytesswentel
#8 1989996-8.patch1.42 KBswentel
PASSED: [[SimpleTest]]: [MySQL] 55,630 pass(es). View
#8 interdiff.txt728 bytesswentel
#4 1989996-4-fail.patch736 bytesswentel
FAILED: [[SimpleTest]]: [MySQL] 55,471 pass(es), 1 fail(s), and 0 exception(s). View
#4 1989996-4-pass.patch1.43 KBswentel
PASSED: [[SimpleTest]]: [MySQL] 55,647 pass(es). View
#1 1989996-1.patch725 bytesswentel
PASSED: [[SimpleTest]]: [MySQL] 55,813 pass(es). View

Comments

swentel’s picture

Status: Active » Needs review
FileSize
725 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,813 pass(es). View
alexpott’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests

:)

swentel’s picture

Issue tags: +Novice, +Configuration system

tagging

swentel’s picture

Status: Needs work » Needs review
FileSize
1.43 KB
PASSED: [[SimpleTest]]: [MySQL] 55,647 pass(es). View
736 bytes
FAILED: [[SimpleTest]]: [MySQL] 55,471 pass(es), 1 fail(s), and 0 exception(s). View
alexpott’s picture

Status: Needs review » Reviewed & tested by the community

Code looks great... bug squashed!

larowlan’s picture

+1

catch’s picture

Status: Reviewed & tested by the community » Needs work

Why not t()?

swentel’s picture

Status: Needs work » Needs review
FileSize
728 bytes
1.42 KB
PASSED: [[SimpleTest]]: [MySQL] 55,630 pass(es). View

Beats me, probably been working in tests to much :)

alexpott’s picture

Status: Needs review » Needs work
+++ b/core/modules/config/lib/Drupal/config/Controller/ConfigController.phpundefined
@@ -94,7 +94,7 @@ public function diff($config_file) {
+    drupal_set_title(t('View changes of @config_file', array('@config_file' => $config_file)));

I think we should be using drupal_set_title(t('blah'), PASS_THROUGH); here

swentel’s picture

Status: Needs work » Needs review
FileSize
730 bytes
1.43 KB
PASSED: [[SimpleTest]]: [MySQL] 56,026 pass(es). View

But of course.

alexpott’s picture

Status: Needs review » Reviewed & tested by the community

Ok... now we're good to go.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.