Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
The patch for the issue id 1953310 has been created. I was wandering if it is moved to the development version of the module. This feature is important for some sites and will be required by most of the users. I am attaching the patch file for the issue which will provide the users with the requirement to show "Send Author a Message" to the anonymous user.
The URL of the issue due to which the patch is generated is as follow: http://drupal.org/node/1953310
Thank you.
Regards,
Tushar
Comments
Comment #2
th_tushar CreditAttribution: th_tushar commentedprivatemsg-SendAuthorAMessage-1953310-7385016.patch queued for re-testing.
Comment #3
BerdirThe patch seems to contain tons of other changes, probably diffed against the wrong branch?
Comment #5
th_tushar CreditAttribution: th_tushar commentedHi Berdir,
Thanks for the suggestion. I will try to regenerate the patch.
Regards,
Tushar
Comment #6
th_tushar CreditAttribution: th_tushar commentedThe new regenerated patch file for the same issue.
Comment #8
ptmkenny CreditAttribution: ptmkenny commentedComment #9
ptmkenny CreditAttribution: ptmkenny commented@Tushar In the future, if you make a patch for an issue, I think it is better to add the patch to the thread of that issue; that makes it easier for people to find. After you add the patch, you can edit the title information for the issue and change it to a bug report/feature request and set the status to "needs review." Those who start an issue are always happy to see a patch.
Comment #10
pinkonomy CreditAttribution: pinkonomy commentedAny news on this issue/patch?
thanks
Comment #11
ptmkenny CreditAttribution: ptmkenny commented@pinkonomy It appears the patch is not passing the tests. It can't be committed until someone fixes it.
Comment #12
pinkonomy CreditAttribution: pinkonomy commentedApart from anonymous being able to sent a message,also on the message "Reply" function should be disabled,is this correct?
Comment #13
ptmkenny CreditAttribution: ptmkenny commentedI haven't reviewed the patch, but since there is no way to respond to anonymous, there definitely should not be a reply form in that case..
Comment #14
ptmkenny CreditAttribution: ptmkenny commented#6: privatemsg-SendAuthorAMessage-1953310-7385016.patch queued for re-testing.
Comment #16
th_tushar CreditAttribution: th_tushar commentedHi,
I have tried to fix this issue and generated the patch for the same. Hope it passes the test.
Thanks,
Tushar
Comment #18
th_tushar CreditAttribution: th_tushar commentedThe patch re-upload with minor changes.
Comment #20
th_tushar CreditAttribution: th_tushar commentedComment #21
th_tushar CreditAttribution: th_tushar commentedHi,
This patch is with respect to the 2.x dev version of the module. Hope it passes the test now.
Thanks,
Tushar
Comment #23
th_tushar CreditAttribution: th_tushar commentedHi All,
I have fixed the issue, facing problem while uploading the patch. Will upload the proper patch soon.!!!!
Regards,
Tushar
Comment #24
th_tushar CreditAttribution: th_tushar commentedThe re-upload of the patch.
Comment #26
th_tushar CreditAttribution: th_tushar commentedHope this could help!!!
Comment #28
th_tushar CreditAttribution: th_tushar commentedComment #30
th_tushar CreditAttribution: th_tushar commentedComment #32
th_tushar CreditAttribution: th_tushar commentedComment #33
th_tushar CreditAttribution: th_tushar commentedHi,
The issue is fixed now and I have uploaded the patch successfully. Please be sure that the permission "Write new private messages" is issued to the Anonymous User on the "admin/people/permission" page, so that anonymous user can send a private message to the content author. Thank You.
Regards,
Tushar
Comment #34
System Lord CreditAttribution: System Lord commentedThis thread is a life/project saver for me!! Thank you for working this issue. (Donate button?) Just one thing. I'm clueless with patches. I hate stating that because I see it on almost every "patch" thread and you coders have to be tired of seeing it. Sorry. Would anyone be willing to walk me through it? I followed some patch instruction before and really fouled things up, so now I'm plenty nervous. And just to verify this patch is for 7.x-2.x-dev?
Thank you,
Mark
Comment #35
System Lord CreditAttribution: System Lord commentedFor my patch question: I don't have a local environment. I work live. I've never used git or drush...fyi. I do have git on my computer, and if this is the preferred way to install patches then I will have to learn it. Please advise.
Comment #36
ptmkenny CreditAttribution: ptmkenny commentedRecently, commits have not been made to Privatemsg very frequently so this is unlikely to get committed soon.
The official drupal.org instructions for applying patches are here:
https://drupal.org/patch/apply
If you're going to install patches, you really should learn at least the basics of git and you should never apply a patch directly to your live environment. I know it's quite a lot to learn for what seems like little return, but in the long run the investment will pay off in reduced frustration when trying to work around bugs.
Comment #37
System Lord CreditAttribution: System Lord commentedThank you for the quick response and for the link. It is quite a lot to learn! haha I just learned drupal. That is to say I've learned drupal well enough to make my site :) Fun but draining! I dread git but know I'll need it. I hope to hire a drupal expert soon! Anyway...
Thanks again, and for all your work with pm!
Curious, is there a way to subscribe to pm where, if I didn't find this thread, I could have been notified of this patch?
Comment #38
System Lord CreditAttribution: System Lord commentedOK, looks like in my situation manual patch is my best option. Your patch seems small enough. Beginning backup...see you in about an hour with the result!
Comment #39
System Lord CreditAttribution: System Lord commentedYES! Works perfectly!
Comment #40
System Lord CreditAttribution: System Lord commentedSo, obviously can't reply to anonymous messages. What about including an "optional" email field visible for anonymous role only? I'm trying to get workflow_field working but getting fatal error. At the very least it would be nice to have help text..
Anonymous user - please include your email if you want the author to reply.
I could probably hack in that statement, but would rather not. Thoughts?
Comment #41
ptmkenny CreditAttribution: ptmkenny commented@System Lord If you are logged in to drupal.org, you can manage your issue notifications for privatemsg here:
https://drupal.org/project/issues/subscribe-mail/privatemsg
Comment #42
System Lord CreditAttribution: System Lord commentedThank you!
Comment #43
Christopher Riley CreditAttribution: Christopher Riley commentedThank you for the patch. It would be great if this was added as a feature that we could turn on and off instead of having to patch the code.
Comment #44
pinkonomy CreditAttribution: pinkonomy commentedThanks for the patch.Question:Is this possible to add other fields in the form like email,name etc?
Comment #45
th_tushar CreditAttribution: th_tushar commentedComment #46
dgtlmoon CreditAttribution: dgtlmoon commentedThis is no more urgent than any other feature request
Comment #48
System Lord CreditAttribution: System Lord commentedI need a way to remove/hide the "Block" action link for anonymous messages only. Right now using "Block" will prevent all messages from any anonymous user. I'm satisfied with my captcha and honeypot configurations for keeping bots at bay.
Maybe even add a "Limits" rule for anonymous or a generic, global (per user) flood control.
Any ideas would be appreciated.
SL
Comment #49
System Lord CreditAttribution: System Lord commentedGiving the "mid" an anonymous class would work for anonymous messages(?) Then admins can do what they want using CSS.
Comment #50
System Lord CreditAttribution: System Lord commentedWhat about adding "Anonymous" to the User Blocking Rules > "If the author has the role" column only?
Comment #51
System Lord CreditAttribution: System Lord commentedI wonder if it's absolutely necessary to ever see message list prefix "Message regarding"? When you have many site using responsive theming to accommodate mobile devices, like me, these kinds of things are a nuisance (respectively) especially in regards to table width (also see: related issue where I have images to show). In the same respect appending "Anonymous" to the message subject line is a space hog and in this case redundant since there's a column for participants already. ( I think the "Anonymous" issue is part of this patch.)
Comment #52
System Lord CreditAttribution: System Lord commentedI may have a solution that addresses anonymous blocking without messing with PM core or this patch and no custom module. The best way I know how to block certain specific anonymous users/visitors is by their IP address. Never 100% fool proof since another IP could be used by the cunning, but it'll work just as well as authenticated user blocking. There's a lot here, but ultimately the end user will have to take very little action to report an anonymous user. Here are my steps...
That's about it.
Now when admin receives the email/form submission they will have the MID in question to click on and in the message they will see the IP address of the anonymous user the authenticated user is wanting to block. From here admins can do whatever they need to do to resolve the issue. Monitor the IP on the site or just block the IP completely.
As for the user's experience...they would click on "Block" in the message enter their description/complaint, and send. Quick and easy!
The obvious down side is someone will have to monitor submissions and act. It can definitely be a full-time job, but IMO well worth it to be able to allow anonymous users to use PM. Maybe I, or someone, can improve on the process in time. Views integration will make this a lot easier, as well (wink).
Other things to consider:
Comment #53
th_tushar CreditAttribution: th_tushar commentedHere is the updated patch for the issue. The "Write new private messages" permission should be assigned to anonymous user to allow anonymous user to view the link and send messages to author.
Comment #54
Narhir CreditAttribution: Narhir as a volunteer commentedHi,
Great patch! but is there a way to make it possible to add conditional field of "email" in privatemsg if the user is anonymous ?
It would be great if the person msged by anonymous would be able to reply to them.
Comment #55
th_tushar CreditAttribution: th_tushar commentedHello @ptmkenny,
The issue is open since more than couple of years till now. Kindly please lets merge the patch and fix/close this issue.
Thanks!
Comment #56
ivnish CreditAttribution: ivnish commentedComment #57
andypostD7 is not yet outdated