This should involve adding the JS ajax lib and data on the link, see #1842036: [META] Convert all confirm forms to use modal dialog for other conversions. Postponed on #1985880: Convert to routing system.

CommentFileSizeAuthor
#9 1988716-ajax-delete-9.patch1.01 KBvijaycs85
#9 1988716-diff-2-9.txt785 bytesvijaycs85
#2 1988716-ajax-delete-2.patch1009 bytesvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Postponed » Active

#1985880: Convert to routing system now committed.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Needs review
FileSize
1988716-ajax-delete-2.patch1009 bytes

Initial patch... However it is failing with 415 (Unsupported media type). Found related issue #1983710: HTTP: Use 406 (Not acceptable) over 415 (Unsupported media type) and applying patch in it made it 406 (Not acceptable).

Lets check with testbot.

Status: Needs review » Needs work

The last submitted patch, 1988716-ajax-delete-2.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs work » Needs review

#2: 1988716-ajax-delete-2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1988716-ajax-delete-2.patch, failed testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

As said in #1842036: [META] Convert all confirm forms to use modal dialog, we should use #attached on the form to add the JS IMHO.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs work » Needs review

#2: 1988716-ajax-delete-2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1988716-ajax-delete-2.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs work » Needs review
FileSize
1988716-diff-2-9.txt785 bytes
1988716-ajax-delete-9.patch1.01 KB

Thanks @Gábor Hojtsy. Updated as #attached.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

I tested this patch quickly on simplytest.me. What happened for me there was that the circle loading sign showed up proper on the delete link but then nothing happened. Seeing "admin/config/system/site-information/translate/delete/af 415 (Unsupported Media Type)" in JS logs, so seems like same issue. How does any of this confirm form stuff work in core now?!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Postponed
Issue tags: +D8MI, +language-config

Same problem applies to #1842036-48: [META] Convert all confirm forms to use modal dialog, so postponing on solving that in core, and then coming back here.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

This does not even seem to happen in core at this point. Keeping it postponed for now.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue summary: View changes
Status: Postponed » Closed (duplicate)

Now that the module is in core, marking this as duplicate of #1842036: [META] Convert all confirm forms to use modal dialog. Now that should cover this one.