With the latest dev version (2013-May-04) there's an error when creating a new backstretch field in a node because default fade time is set to 0 (it was 750 i believe). Setting image field to unlimited, change the value to 750 and change unlimited back to 1 solves the problem.

Notice: Undefined index: fade in backstretch_field_formatter_view() (line 314 in ../backstretch.module).

B.t.w: ability to change single image fade would be nice :)

CommentFileSizeAuthor
#4 unidentified-index-fade-1988318-4.patch745 bytesjeni_dc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yannickoo’s picture

Status: Active » Fixed

Oh sorry, that happened if the value is zero, fixed with c807887.

The other suggestion is related to this issue #1977740: Suggestion: Expose duration and fade config even if field is not multiple value.

juliusvaart’s picture

Thanks yannickoo.

Great work on this module and the quick issue response!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jeni_dc’s picture

Status: Closed (fixed) » Needs review
FileSize
745 bytes

I'm changing this to needs review since the same problem was happening with the context integration. I've attached a patch that fixes this, which is just the same fix from the patch mentioned above.

guy_schneerson’s picture

Status: Needs review » Reviewed & tested by the community

managed to recreate the issue by installing the module & creating a context that activates backstretch and got the error.
The patch in #4 fixed the issue.

yannickoo’s picture

Status: Reviewed & tested by the community » Fixed

Cool, thank you jeni_dc, fixed with c178a85. You should name the patch correctly. See Submitting patches:

This is an important step as it makes managing patches easier for people who work with many patches at once (e.g. core committers). Adopting a standardized naming convention such as [module_name]-[short-description]-[issue-number]-[comment-number].patch is very helpful.

For example, a patch about the forum module's comment titles attached to comment #15 of issue #12345 should be named: forum-comment-titles-12345-15.patch

guy_schneerson’s picture

Hi yannickoo Was wondering about the state of the patch naming. I have been following the instructions on the project version control page https://drupal.org/project/backstretch/git-instructions although I think adding the module name is better.
do you know which of the two is more up to date?

yannickoo’s picture

Oh, good to know. I will post an issue I posted an issue (#2012538: "Creating a patch" section on the "Version control" page) in the Drupal.org webmasters issue queue. Please use the module name as prefix in the patch name :)

guy_schneerson’s picture

nice one yannickoo :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.