Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
With the latest dev version (2013-May-04) there's an error when creating a new backstretch field in a node because default fade time is set to 0 (it was 750 i believe). Setting image field to unlimited, change the value to 750 and change unlimited back to 1 solves the problem.
Notice: Undefined index: fade in backstretch_field_formatter_view() (line 314 in ../backstretch.module).
B.t.w: ability to change single image fade would be nice :)
Comment | File | Size | Author |
---|---|---|---|
#4 | unidentified-index-fade-1988318-4.patch | 745 bytes | jeni_dc |
Comments
Comment #1
yannickooOh sorry, that happened if the value is zero, fixed with c807887.
The other suggestion is related to this issue #1977740: Suggestion: Expose duration and fade config even if field is not multiple value.
Comment #2
juliusvaart CreditAttribution: juliusvaart commentedThanks yannickoo.
Great work on this module and the quick issue response!
Comment #4
jeni_dc CreditAttribution: jeni_dc commentedI'm changing this to needs review since the same problem was happening with the context integration. I've attached a patch that fixes this, which is just the same fix from the patch mentioned above.
Comment #5
guy_schneerson CreditAttribution: guy_schneerson commentedmanaged to recreate the issue by installing the module & creating a context that activates backstretch and got the error.
The patch in #4 fixed the issue.
Comment #6
yannickooCool, thank you jeni_dc, fixed with c178a85. You should name the patch correctly. See Submitting patches:
Comment #7
guy_schneerson CreditAttribution: guy_schneerson commentedHi yannickoo Was wondering about the state of the patch naming. I have been following the instructions on the project version control page https://drupal.org/project/backstretch/git-instructions although I think adding the module name is better.
do you know which of the two is more up to date?
Comment #8
yannickooOh, good to know.
I will post an issueI posted an issue (#2012538: "Creating a patch" section on the "Version control" page) in the Drupal.org webmasters issue queue. Please use the module name as prefix in the patch name :)Comment #9
guy_schneerson CreditAttribution: guy_schneerson commentednice one yannickoo :)