Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

Files: 
CommentFileSizeAuthor
#19 interdiff.txt3.61 KBMile23
#19 1987890_19.patch6.71 KBMile23
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,225 pass(es). View
#17 1987890_17_reroll_13.patch3.1 KBMile23
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,840 pass(es). View
#13 drupal8.update-module.1987890-13.patch5.67 KBundertext
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,324 pass(es). View
#9 1987890-9.patch5.75 KBpwolanin
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 1987890-9.patch. Unable to apply patch. See the log in the details link for more information. View
#6 drupal8.update-module.1987890-6.patch6.82 KBdisasm
FAILED: [[SimpleTest]]: [MySQL] 58,064 pass(es), 43 fail(s), and 0 exception(s). View
#4 drupal8.update-module.1987890-4.patch6.81 KBdisasm
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal8.update-module.1987890-4.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

vijaycs85’s picture

Status: Active » Closed (won't fix)

Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.

ayelet_Cr’s picture

Status: Closed (won't fix) » Active
disasm’s picture

Assigned: Unassigned » disasm
disasm’s picture

Status: Active » Needs review
FileSize
6.81 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal8.update-module.1987890-4.patch. Unable to apply patch. See the log in the details link for more information. View

attached patch converts to new controller.

Status: Needs review » Needs work

The last submitted patch, drupal8.update-module.1987890-4.patch, failed testing.

disasm’s picture

Status: Needs work » Needs review
FileSize
6.82 KB
FAILED: [[SimpleTest]]: [MySQL] 58,064 pass(es), 43 fail(s), and 0 exception(s). View

Status: Needs review » Needs work

The last submitted patch, drupal8.update-module.1987890-6.patch, failed testing.

xjm’s picture

Thanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.

pwolanin’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
5.75 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 1987890-9.patch. Unable to apply patch. See the log in the details link for more information. View

re-roll and change to use ControllerBase to simplify the conversion

xjm’s picture

9: 1987890-9.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 9: 1987890-9.patch, failed testing.

xjm’s picture

Issue tags: +Needs reroll
undertext’s picture

Status: Needs work » Needs review
FileSize
5.67 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,324 pass(es). View
m1r1k’s picture

Issue tags: +#ams2014contest
Cottser’s picture

Assigned: disasm » Unassigned
Issue tags: -Needs reroll, -
Mile23’s picture

Mile23’s picture

FileSize
3.1 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,840 pass(es). View

Reroll.

valthebald’s picture

Status: Needs review » Needs work

Can we remove update_test_mock_page() from update_test.module?

Mile23’s picture

Status: Needs work » Needs review
FileSize
6.71 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,225 pass(es). View
3.61 KB

Done.

valthebald’s picture

Status: Needs review » Reviewed & tested by the community

Looks good now!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Changes to tests are not frozen and it's good to be getting the final WSCCI conversions done. Committed 4f03557 and pushed to 8.0.x. Thanks!

  • alexpott committed 4f03557 on 8.0.x
    Issue #1987890 by Mile23, disasm, undertext, pwolanin: Convert...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.