Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

#10 wscci-1987804-10.patch2.73 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 59,283 pass(es). View
#10 interdiff.txt825 bytesdawehner
#9 drupal8.plugin_test.1987804-9.patch2.72 KBdisasm
PASSED: [[SimpleTest]]: [MySQL] 59,126 pass(es). View
#9 interdiff.txt1.48 KBdisasm
#6 drupal8.plugin_test.1987804-6.patch2.66 KBdisasm
PASSED: [[SimpleTest]]: [MySQL] 58,158 pass(es). View


vijaycs85’s picture

Status: Active » Closed (won't fix)

Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.

ayelet_Cr’s picture

Status: Closed (won't fix) » Active
Sean Buscay’s picture

Assigned: Unassigned » Sean Buscay
Sean Buscay’s picture

Assigned: Sean Buscay » Unassigned

Erroneously assigned.

disasm’s picture

Assigned: Unassigned » disasm
disasm’s picture

Status: Active » Needs review
2.66 KB
PASSED: [[SimpleTest]]: [MySQL] 58,158 pass(es). View

attached patch converts plugin_test_definition callback.

xjm’s picture

Thanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.

dawehner’s picture

Status: Needs review » Needs work
  1. +++ b/core/modules/system/tests/modules/plugin_test/lib/Drupal/plugin_test/Controller/PluginTest.php
    @@ -0,0 +1,32 @@
    +  function testDefinitions() {

    Let's make that public

  2. +++ b/core/modules/system/tests/modules/plugin_test/lib/Drupal/plugin_test/Controller/PluginTest.php
    @@ -0,0 +1,32 @@
    +    foreach($manager->getDefinitions() as $plugin_id => $definition) {

    There should be a space after the foreach.

  3. +++ b/core/modules/system/tests/modules/plugin_test/plugin_test.module
    @@ -24,24 +22,7 @@ function plugin_test_menu() {
         'access callback' => TRUE,

    No need to keep access callback on there.

disasm’s picture

Status: Needs work » Needs review
1.48 KB
2.72 KB
PASSED: [[SimpleTest]]: [MySQL] 59,126 pass(es). View
dawehner’s picture

Status: Needs review » Reviewed & tested by the community
825 bytes
2.73 KB
PASSED: [[SimpleTest]]: [MySQL] 59,283 pass(es). View

Just fixing some docs and empty lines.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.