Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

Files: 
CommentFileSizeAuthor
#10 drupal-1987574-10.patch1.58 KBmrded
FAILED: [[SimpleTest]]: [MySQL] 58,206 pass(es), 26 fail(s), and 2 exception(s). View
#9 drupal-1987574-8.patch3.64 KBmrded
FAILED: [[SimpleTest]]: [MySQL] 58,485 pass(es), 3 fail(s), and 2 exception(s). View
#7 drupal-1987574-7.patch3.73 KBmrded
FAILED: [[SimpleTest]]: [MySQL] 58,069 pass(es), 3 fail(s), and 2 exception(s). View

Comments

ParisLiakos’s picture

ayelet_Cr’s picture

Status: Closed (won't fix) » Active
mparker17’s picture

Assigned: Unassigned » mparker17

I will help!

mparker17’s picture

Assigned: mparker17 » Unassigned

Unassigning myself as @seanbuscay will take care of it.

Sean Buscay’s picture

Assigned: Unassigned » Sean Buscay
mrded’s picture

Issue tags: +LONDON_2013_AUGUST

Working on this as part of London sprint.

mrded’s picture

Assigned: Sean Buscay » mrded
Status: Active » Needs review
FileSize
3.73 KB
FAILED: [[SimpleTest]]: [MySQL] 58,069 pass(es), 3 fail(s), and 2 exception(s). View

Please, take a look my path.

vijaycs85’s picture

Status: Needs review » Needs work
  1. +++ b/core/modules/system/tests/modules/session_test/lib/Drupal/session_test/Controller/SessionTestController.php
    @@ -0,0 +1,42 @@
    +   */
    

    Can inherit or remove, if we are not doing any in __construct, we can remove it.

  2. +++ b/core/modules/system/tests/modules/session_test/session_test.routing.yml
    @@ -0,0 +1,6 @@
    -- 
    

    Missing empty line at the end.

mrded’s picture

Status: Needs work » Needs review
FileSize
3.64 KB
FAILED: [[SimpleTest]]: [MySQL] 58,485 pass(es), 3 fail(s), and 2 exception(s). View

New version.

mrded’s picture

FileSize
1.58 KB
FAILED: [[SimpleTest]]: [MySQL] 58,206 pass(es), 26 fail(s), and 2 exception(s). View

Sorry, forgot to change controller's name.

Status: Needs review » Needs work

The last submitted patch, drupal-1987574-10.patch, failed testing.

disasm’s picture

Status: Needs work » Closed (duplicate)

Please work on this here: #1987572: Convert session_test callbacks to a new style controller. There's already a patch that has conversions for all the session_test callbacks. It just needs the tests fixed.