Motivation

Currently many templates look like:

{{ link_prev }}
{{ link_next }}

We however would like this to look like:

<a href="{{ link_prev.url }}"{{ link_prev.attributes }}>{{ Previous|'t' }}</a>
<a href="{{ link_next.url }}"{{ link_next.attributes }}>{{ Next|'t' }}</a>

so that it looks like HTML, not like render array things, but {{ link_prev }} should still be possible.

However using the unprocessed URL would lead to XSS problems and non-absolute paths, which would be broken.

Proposed resolution

With the introduction of Markup Utility functions many basic theme elements become alterable, but are by default not themeable.
That way, code can call l() that needs a fast link, but other code can call l(..., array('render' => FALSE)) to get the structure.

The idea is to then use the following code in a Twig template:

{% muf_embed link_prev %}
<a href="{{ url }}"{{ attributes }}>{{ 'Previous'|t }}</a>
{% end muf_embed %}

This is not slower than directly letting drupal_render call the MUF as the compiled PHP code would look like:

$context['parent'] = $context;
$context = twig_call_muf($context['link_prev']);
print '<a href="'
print twig_render_var($context['url']);
print '"';
print twig_render_var($context['url']);
print'>';
print t('Previous');
print '</a>';
print "\n";
$context = $context['parent'];

It looses however the flexibility of any #pre_render, #post_render, or other structure that might have been added to the link_prev.

This is okay as MUFs are mainly only alterable and someone might chose to use l() directly anyway.

Remaining tasks

* Patch
* Tests
* Documentation

API changes

The introduction of muf_embed function in Twig templates.

- #1986116: Improve performance by replacing very small and simple templates and theme function with "Markup Utility Functions"
- #1985974: Make l() optionally return structured output

Comments

thedavidmeister’s picture

Status: Active » Postponed

This looks great but it needs to be postponed on the "related issues" being sorted first.

Fabianx’s picture

This is even more useful for something like:

{% muf_embed {theme:'link', path: 'node/1'} %}
<a href="{{ url }}" class="my-nice-link do-not-need-active-class-or-other-attributes">{{ 'My own text'|t }}</a>
{% end muf_embed %}
Fabianx’s picture

Issue summary: View changes

added a related issue

mgifford’s picture

lauriii’s picture

Version: 8.0.x-dev » 8.1.x-dev

We might be able to do this kind of changes by adding multiple variables and Stable.

joelpittet’s picture

Assigned: Fabianx » Unassigned
Status: Postponed » Active

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.