Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dicreat’s picture

Sorry for mistake in post below with tag <a> :(

jcnventura’s picture

Status: Active » Postponed (maintainer needs more info)

Indeed it does, but why is this a problem?

There is a step to convert all spaces to %20 so that when I try to split on spaces to detect the href attribute I can be sure that it is an attribute and not an href inside an attribute value.

The side effect is that all spaces are no longer spaces. This is no problem in href attributes as a later urldecode call converts them all back into spaces. Other attributes should no longer be relevant (such as the title attribute). So can you tell me why it is important?

Thanks,

João Ventura

jpereza’s picture

FileSize
54.56 KB

It is important because the original link had not that %20 in the title attribute, and now it has. Really, it is not a very important bug, but it is a bug.

You could be thinking that the title attribute does not shows when printed in paper, so it is not important. Yes, that's right.

But just figures that you could be using the printer-friendly page in order to view a book page with all of its children pages. In this scenario, you could click in the links and hold the cursor over the link to see the title of that link. Then, you would see the %20 that difficult reading the tooltip text.

See the attached image for an example.

PS: Very good module!

jcnventura’s picture

Status: Postponed (maintainer needs more info) » Fixed

Code to remove the added %20s has now been committed to CVS.

João

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.