Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I can only get this to work for the different frontpages on my domains, not individual nodes or defaults. Is that intended?
Comment | File | Size | Author |
---|---|---|---|
#20 | twitter account.png | 101.04 KB | rich.3po |
#19 | domain-global-context-1986650-19.patch | 466 bytes | rich.3po |
#9 | domain-global-context-1986650-9.patch | 1.65 KB | rich.3po |
Comments
Comment #1
artofeclipse CreditAttribution: artofeclipse commentedyes this is intended, because you can use metatag module to do this functionality for content and content types.
I think it's odd thing to have diffrent metatag for the content type in diffrent domain of the same website, what do you think?
Comment #2
artofeclipse CreditAttribution: artofeclipse commentedif this is a case you got and need it as a feature I will add it, but please could you add more details of what is the features you want to have?
Comment #3
remkovdz CreditAttribution: remkovdz commentedPlease see this: http://drupal.org/node/1399724#comment-7326984
I think that is a valid use case, thanks a lot.
Comment #4
artofeclipse CreditAttribution: artofeclipse commentedComment #5
remkovdz CreditAttribution: remkovdz commentedHi, will such à feature be available?
Comment #6
artofeclipse CreditAttribution: artofeclipse commentedSorry I was changing it to needs work, I will work on this one soon.
Comment #7
remkovdz CreditAttribution: remkovdz commentedGreat! Let me know if I can do anything to help.
Comment #8
4kant CreditAttribution: 4kant commentedYeah - soon would be nice ;-) Thanks anyway!
Comment #9
rich.3po CreditAttribution: rich.3po commentedHi - here is a go at a patch for this one. I've also added missing dependencies to the .info file
Comment #10
rich.3po CreditAttribution: rich.3po commentedComment #12
artofeclipse CreditAttribution: artofeclipse commented@rich.3po Thanks for posting this patch, I will test it and push it.
Comment #14
artofeclipse CreditAttribution: artofeclipse commentedOK, so after a long time finally I had the time to fix this issue, I pushed some code changes to the dev, and by now there is a new dev release, I just will wait for 2 more days to test it more and after I make sure there is no problem I will create a new release.
Ma'moun othman.
Comment #15
artofeclipse CreditAttribution: artofeclipse commentedComment #16
artofeclipse CreditAttribution: artofeclipse commentedThis will need database update to make the old settings compatible with the new changes.
Comment #18
artofeclipse CreditAttribution: artofeclipse commentedChange to needs review.
Comment #19
rich.3po CreditAttribution: rich.3po commentedHi, i've been testing your patch - ie the latest dev release - and noticed a few issues
Firstly, domain-specific instances are being activated in some cases where you dont want them to be. Eg i have a master config for a 'section index' node type, which is not domain-specific
So it should activate:
node:section_index
.. but instead in activates
my_domain:node:section_index
which does not exist, but kills all my settings. I've created a patch to fix this
Comment #20
rich.3po CreditAttribution: rich.3po commentedSecondly, there seems to be an issue with naming 'global' domain contexts as just the domain name. The dev release uses eg
"my_domain"
to represent the global context for that domain. However this causes problems because the Metatag module needs to apply special handling to 'global' contexts, and it detects them by checking the first part of the context name. In other words, the context should be called:
"global:my_domain"
as per my patch in #9
If this is not the case, then you dont see some metatags such as the "Site's Twitter account" which are marked as applicable to 'global only' (see screenshot).
Renaming the context in this way seems to fix this, but makes the interface look a bit messy, ie some domain contexts are with the "domain" fieldset, and global ones are outside of it... Any thoughts on this?
Comment #21
ExTexan CreditAttribution: ExTexan commentedHi All,
Can someone tell me the status of this? Is it ready for a production site?
I need domain-specific globals because, for each of my domains, I want to add the abbreviation in ( ) to show in search engine results without it showing in the site name shown on each page of each site.
For example:
Global:
[current-page:title] | [site:name] (MRR) <----- for MyRealRacing.club
[current-page:title] | [site:name] (MPC) <----- for MyProjectCars.club
...etc. for 8 other sites
Front page:
[site:name] (MRR) | [site:slogan] <----- for MyRealRacing.club
[site:name] (MPC) | [site:slogan] <----- for MyProjectCars.club
...etc. for 8 other sites
Obviously, with the unpatched version of this module, I can only do the front page configuration.
Comment #22
harry_nc CreditAttribution: harry_nc commentedI don't this think implementation is the best way forward, why not duplicate the workflow for every other DA module and have the basic 'save these settings for x domain'? This is a much cleaner way and keeps all the helped DA modules consistent. The implementation in this module doesn't appear to work correctly (I can only see options for 1 domain), and doesn't allow quick overrides based on common settings.
I would say the module isn't ready for production sites yet based on lack of features/workflow & bugs
Comment #23
artofeclipse CreditAttribution: artofeclipse commentedHello @harry_nc, Thank your for your comment, actually this module now support all entity types for all domains, but need some testing.
You should try the dev version of this module to be able to test it.
Thanks.
Comment #24
theroyal CreditAttribution: theroyal commented@artofeclipse are you talking about the dev version ?
is it safe for production website ?
Comment #25
artofeclipse CreditAttribution: artofeclipse commented@theroyal, the new changes are commit to the dev release, and its ready to use on production, but no harm in testing first just to make sure that its working as intended to be on production.
let me know if you face any issues.
Comment #26
tommycox CreditAttribution: tommycox as a volunteer commentedI know this is three years down the road, but found a recent use case for this and couldn't for the life of me get it to work for specific content types, just a specific domain's content in general.
Line 95 of domains_metatag.module
...
$entity->$instance_config[$arg]['bundle']
$instance_config[$arg]['bundle']
needs to be wrapped in brackets like so$entity->{$instance_config[$arg]['bundle']}
Will submit a patch if I get a chance, although I'm sure this project has gone the way of the dodo.