Update core's normalize.css library from v2.0.1 (8/20/12) to v2.1.1 (5/7/13) to help #1839318: Replace drupal.base.css library with normalize.css for all themes and #1924430: Add drupal.base library for base CSS styles stay current.

CommentFileSizeAuthor
#8 4-7-interdiff.txt3.2 KBalexpott
#7 update-normalize-1986616-7.patch19.48 KBechoz
#5 normalizebefore1.png57.84 KBandymartha
#5 normalizeafter1.png89.41 KBandymartha
#4 update-normalize-1986616-4.patch19.46 KBechoz
#1 update-normalize-1986616.patch19.75 KBechoz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

echoz’s picture

echoz CreditAttribution: echoz commented
Status: Active » Needs review
FileSize
update-normalize-1986616.patch19.75 KB

Status: Needs review » Needs work
Issue tags: -Front end, -d8mux-css-cleanup

The last submitted patch, update-normalize-1986616.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Needs work » Needs review
Issue tags: +Front end, +d8mux-css-cleanup

#1: update-normalize-1986616.patch queued for re-testing.

echoz’s picture

echoz CreditAttribution: echoz commented
FileSize
update-normalize-1986616-4.patch19.46 KB

new patch, because they reverted the last commit (5/7/13, no version change) that seemed potentially problematic.

andymartha’s picture

andymartha CreditAttribution: andymartha commented
Status: Needs review » Reviewed & tested by the community
FileSize
normalizeafter1.png89.41 KB
normalizebefore1.png57.84 KB

After applying patch update-normalize-1986616-4.patch from #4 by echoz to a fresh Drupal 8 install, it looks like the normalize library was updated to version 2.1.1. See screenshots with no perceived detriment in functionality.

normalizebefore1.png

normalizeafter1.png

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

Oh darn... normalize.css v2.1.2 has been released.... the only change from the version in this patch is:

diff ../normalize.css core/misc/normalize/normalize.css
1c1
< /*! normalize.css v2.1.2 | MIT License | git.io/normalize */
---
> /*! normalize.css v2.1.1 | MIT License | git.io/normalize */

But in order to be consistent with the normalise project we need to update to 2.1.2

echoz’s picture

echoz CreditAttribution: echoz commented
Status: Needs work » Needs review
FileSize
update-normalize-1986616-7.patch19.48 KB

yet another patch :-)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
FileSize
4-7-interdiff.txt3.2 KB

Here's an interdiff of 4 to 7 for reviewers...

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Status: Needs review » Needs work 
diff --git a/core/misc/normalize/CHANGELOG.md b/core/misc/normalize/CHANGELOG.md
old mode 100644
new mode 100755

The patch is perfect EXCEPT the file permissions all change from 644 to 755. Can we fix those file permissions and then re-roll the patch?

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Status: Needs work » Reviewed & tested by the community

Alexpott said he'll fix the file permissions before he commits. RTBC from me then! :-D

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 0311348 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

now normalize.css 5/7/13 commit of v2.1.1