Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There is some code in mytube.module for D6 (I haven't tested in D7) that checks if the embed domain is the current domain, and if so, doesn't do the image replacement, but it seems to be relying on a global variable that isn't set anywhere else. Rather than setting that variable elsewhere, it seems to make sense to me to use the core Drupal base_url variable. Patch forthcoming.
Comment | File | Size | Author |
---|---|---|---|
#1 | mytube-base_domain_fix-1985090-1.patch | 896 bytes | mcarbone |
Comments
Comment #1
mcarbone CreditAttribution: mcarbone commentedComment #2
l@va CreditAttribution: l@va commentedAwesome, thank you so much for your patch! I'm really busy for the next few days, but I'll take a closer look and submit it shortly. I think D7 is using
embed_url
instead of_mytube_base_url
(and peculiarly sets_mytube_base_url
but never uses it) so usingembed_url
might be preferential.Leaving issue open until further notice.
Comment #3
mfbIn the Drupal 7 branch, it appears that the trusted domain functionality causes an empty domain to be trusted. In addition, the base domain(s) of the site can be defined there. So I believe this is fixed in that branch.