OA2: Excessive empty line in marked-down diff [#1982450]

oa_html_to_text() adds an excessive empty line to the end our marked-down diff:

Now this is not really our fault, as the default drupal_html_to_text() does the same thing, but we'll want to keep track how this being solved on diff modules's side.
Atm, this doesn't seem important enough to apply a patch from our side, but if diff module decides to override drupal_html_to_text(), we'll want to use that as well for oa_html_to_text().
Therefore postponed on #1982432: Remove excessive empty line in marked-down diff

Comment	File	Size	Author
	markdown-excessive-linebreak.png	11.93 KB	Pancho

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Argus CreditAttribution: Argus commented 1 January 2014 at 23:21

Issue summary:	View changes
Status:	Postponed	» Needs work

#1982432: Remove excessive empty line in marked-down diff is fixed.

Comment #2

Argus CreditAttribution: Argus commented 1 January 2014 at 23:24

Version:	7.x-2.0-alpha2	» 7.x-2.x-dev
Status:	Needs work	» Active

Comment #3

mpotter CreditAttribution: mpotter commented 7 January 2014 at 18:30

Status:

Active

» Postponed

Still postponed until they release a new version of "diff". The OA version calls the diff.pages.inc file so changes there will automatically be incorporated into Open Atrium. But they have done many changes since the 3.2 version being used in OA2 so as soon as they release a new version I'll test it out.