Files: 
CommentFileSizeAuthor
#30 1981334-30.patch31.75 KBpcambra
PASSED: [[SimpleTest]]: [MySQL] 57,741 pass(es).
[ View ]
#27 1981334-27.patch31.59 KBpcambra
PASSED: [[SimpleTest]]: [MySQL] 58,061 pass(es).
[ View ]
#21 1981334-21.patch31.73 KBswentel
PASSED: [[SimpleTest]]: [MySQL] 56,271 pass(es).
[ View ]
#21 interdiff.txt657 bytesswentel
#20 interdiff.txt3.52 KBpcambra
#20 1981334-20.patch31.71 KBpcambra
PASSED: [[SimpleTest]]: [MySQL] 56,178 pass(es).
[ View ]
#16 1981334-14.patch30.12 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981334-14_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#14 1981334-14.patch30.93 KBpcambra
FAILED: [[SimpleTest]]: [MySQL] 55,832 pass(es), 2 fail(s), and 5 exception(s).
[ View ]
#14 interdiff.txt6.76 KBpcambra
#12 1981334-12.patch26.74 KBaspilicious
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/options/lib/Drupal/options/Tests/OptionsWidgetsTest.php.
[ View ]
#8 1981334-8.patch21.64 KBswentel
FAILED: [[SimpleTest]]: [MySQL] 55,971 pass(es), 8 fail(s), and 1 exception(s).
[ View ]
#1 1953410-cud-1981334-1.patch22.43 KBandypost
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1953410-cud-1981334-1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

andypost’s picture

Status:Active» Needs review
StatusFileSize
new22.43 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1953410-cud-1981334-1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
andypost’s picture

Issue tags:+Field API

taggin

andypost’s picture

Issue tags:+Novice

tagged to office hours

swentel’s picture

Status:Needs review» Closed (won't fix)

We're going todo this in one patch.

swentel’s picture

Status:Closed (won't fix)» Needs review

So we agreed to this in chunks anyway.

swentel’s picture

Issue tags:-Novice, -Field API

#1: 1953410-cud-1981334-1.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice, +Field API

The last submitted patch, 1953410-cud-1981334-1.patch, failed testing.

swentel’s picture

Status:Needs work» Needs review
StatusFileSize
new21.64 KB
FAILED: [[SimpleTest]]: [MySQL] 55,971 pass(es), 8 fail(s), and 1 exception(s).
[ View ]

rerolled

Status:Needs review» Needs work
Issue tags:-Novice, -Field API

The last submitted patch, 1981334-8.patch, failed testing.

swentel’s picture

Status:Needs work» Needs review

#8: 1981334-8.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice, +Field API

The last submitted patch, 1981334-8.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review
StatusFileSize
new26.74 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/options/lib/Drupal/options/Tests/OptionsWidgetsTest.php.
[ View ]

Lets see if I made typos...

Status:Needs review» Needs work

The last submitted patch, 1981334-12.patch, failed testing.

pcambra’s picture

StatusFileSize
new6.76 KB
new30.93 KB
FAILED: [[SimpleTest]]: [MySQL] 55,832 pass(es), 2 fail(s), and 5 exception(s).
[ View ]

Here we go

pcambra’s picture

Status:Needs work» Needs review
aspilicious’s picture

StatusFileSize
new30.12 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981334-14_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Rerolled and tried to fix typos

Status:Needs review» Needs work

The last submitted patch, 1981334-14.patch, failed testing.

aspilicious’s picture

Status:Needs work» Needs review

:)

aspilicious’s picture

I'll leave this one for pcambra

pcambra’s picture

Assigned:Unassigned» pcambra
StatusFileSize
new31.71 KB
PASSED: [[SimpleTest]]: [MySQL] 56,178 pass(es).
[ View ]
new3.52 KB

Not sure what the typos were fixed by @aspilicious, we really could use interdiffs here :)

Fixed a couple of things regarding node access tests.

swentel’s picture

Status:Needs review» Reviewed & tested by the community
StatusFileSize
new657 bytes
new31.73 KB
PASSED: [[SimpleTest]]: [MySQL] 56,271 pass(es).
[ View ]

wonderful again, thanks!

One nitpick in the docs.

alexpott’s picture

Issue tags:-Novice, -Field API

#21: 1981334-21.patch queued for re-testing.

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 1981334-21.patch, failed testing.

andypost’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +Field API

#21: 1981334-21.patch queued for re-testing.

andypost’s picture

Status:Needs review» Reviewed & tested by the community

back to rtbc

alexpott’s picture

Status:Reviewed & tested by the community» Needs work

Needs a reroll...

curl https://drupal.org/files/1981334-21.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 32494  100 32494    0     0  12675      0  0:00:02  0:00:02 --:--:-- 13774
error: patch failed: core/modules/options/lib/Drupal/options/Tests/OptionsFieldTest.php:61
error: core/modules/options/lib/Drupal/options/Tests/OptionsFieldTest.php: patch does not apply
pcambra’s picture

Status:Needs work» Needs review
StatusFileSize
new31.59 KB
PASSED: [[SimpleTest]]: [MySQL] 58,061 pass(es).
[ View ]

Catching up with HEAD.

swentel’s picture

Status:Needs review» Needs work
+++ b/core/modules/node/lib/Drupal/node/Tests/NodeAccessLanguageAwareCombinationTest.phpundefined
@@ -35,6 +35,13 @@ class NodeAccessLanguageAwareCombinationTest extends NodeTestBase {
+   * @var \Drupal\user\Plugin\Core\Entity\User.

should be interface no ?

You can mark it RTBC when you re-roll

andypost’s picture

Yes, this needs to be a interface

pcambra’s picture

Status:Needs work» Needs review
StatusFileSize
new31.75 KB
PASSED: [[SimpleTest]]: [MySQL] 57,741 pass(es).
[ View ]

Here we go, changed to UserInterface

pcambra’s picture

Status:Needs review» Reviewed & tested by the community
andypost’s picture

Maybe we should convert this to FieldDefinitionInterface?

+++ b/core/modules/number/lib/Drupal/number/Tests/NumberFieldTest.phpundefined
@@ -22,8 +22,25 @@ class NumberFieldTest extends WebTestBase {
+   * @var \Drupal\field\Plugin\Core\Entity\Field

+++ b/core/modules/options/lib/Drupal/options/Tests/OptionsWidgetsTest.phpundefined
@@ -22,6 +22,35 @@ class OptionsWidgetsTest extends FieldTestBase {
+   * @var \Drupal\field\Plugin\Core\Entity\Field
...
+   * @var \Drupal\field\Plugin\Core\Entity\Field
...
+   * @var \Drupal\field\Plugin\Core\Entity\Field

See #1950632: Create a FieldDefinitionInterface and use it for formatters and widgets

pcambra’s picture

I've created #2022207: User test vars declared as \Drupal\user\Plugin\Core\Entity\User where it should be \Drupal\user\UserInterface for the UserInterface docs cleanup, maybe that one should be a followup too?

andypost’s picture

Makes sense! docs could be cleaned after july 1

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed a4bfb01 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.