For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

Meta issue: #1971384: [META] Convert page callbacks to controllers

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim-e’s picture

Assigned: Unassigned » tim-e
tim-e’s picture

Status: Active » Needs review
FileSize
1.11 KB

Patch attached.

larowlan’s picture

+++ b/core/modules/comment/comment.routing.ymlundefined
@@ -0,0 +1,6 @@
\ No newline at end of file

needs a blank line

larowlan’s picture

also comment_edit_page() function can go.

larowlan’s picture

Status: Needs review » Needs work
tim-e’s picture

Status: Needs work » Needs review
FileSize
1.64 KB

Again

larowlan’s picture

Issues with the title are part of the bigger issue in #1871596: Create a PartialResponse class to encapsulate html-level data [Moving to sandbox]
Wondering if we have tests for that... lets see what bot says first.

larowlan’s picture

Status: Needs review » Reviewed & tested by the community

Yeah this is freaking awesome, #1913618: Convert EntityFormControllerInterface to extend FormInterface by tim.plunkett, amateescu makes it so simple.

tim.plunkett’s picture

Fixing tags

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 01b33f5 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.