Add Modernizr to the .jshintrc file [#1976964]

Modernizr is included on all page loads. It should be included in the list of globals that are predefined.

Comment	File	Size	Author
	jshint-modernizr.patch	212 bytes	jessebeach

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jessebeach CreditAttribution: jessebeach commented 22 April 2013 at 19:35

Status:

Active

» Needs review

One line addition to the .jshintrc file.

Comment #2

seutje CreditAttribution: seutje commented 22 April 2013 at 19:45

Makes sense.

Comment #3

RobLoach

he/him

CreditAttribution: RobLoach commented 22 April 2013 at 20:10

Status:

Needs review

» Reviewed & tested by the community

$ git apply jshint-modernizr.patch
$ cd core
$ jshint .
misc/autocomplete.js: line 230, col 52, Don't make functions within a loop.
misc/autocomplete.js: line 231, col 55, Don't make functions within a loop.
misc/autocomplete.js: line 232, col 56, Don't make functions within a loop.
misc/autocomplete.js: line 319, col 9, 'alert' is not defined.

misc/drupal.js: line 1, col 5, Redefinition of 'Drupal'.

modules/contextual/contextual.js: line 144, col 24, Did you mean to return a conditional instead of an assignment?

modules/contextual/contextual.toolbar.js: line 191, col 52, Missing semicolon.

modules/edit/js/backbone.drupalform.js: line 96, col 26, Bad escaping.
modules/edit/js/backbone.drupalform.js: line 96, col 35, Bad escaping.

modules/edit/js/views/toolbar-view.js: line 224, col 29, Expected '!==' and instead saw '!='.

modules/views/views_ui/js/views-admin.js: line 1018, col 50, A leading decimal point can be confused with a dot: '.85'.
modules/views/views_ui/js/views-admin.js: line 1018, col 50, Missing radix parameter.
modules/views/views_ui/js/views-admin.js: line 1019, col 49, A leading decimal point can be confused with a dot: '.6'.
modules/views/views_ui/js/views-admin.js: line 1019, col 49, Missing radix parameter.
modules/views/views_ui/js/views-admin.js: line 1027, col 51, A leading decimal point can be confused with a dot: '.8'.
modules/views/views_ui/js/views-admin.js: line 1027, col 51, Missing radix parameter.
modules/views/views_ui/js/views-admin.js: line 1042, col 54, Missing radix parameter.
modules/views/views_ui/js/views-admin.js: line 1043, col 57, Missing radix parameter.
modules/views/views_ui/js/views-admin.js: line 1057, col 52, Missing radix parameter.
modules/views/views_ui/js/views-admin.js: line 1058, col 55, Missing radix parameter.
modules/views/views_ui/js/views-admin.js: line 1103, col 3, Missing semicolon.

21 errors

Once we have #1473066: [Meta] Move third-party assets out of core/misc folder, we'll be able to ignore all .js vendor code easily.