This is a child task of #1775842: [meta] Convert all variables to state and/or config systems. I think this should be changed to state.

Files: 
CommentFileSizeAuthor
#6 drupal-1975114-6.patch774 bytesdawehner
PASSED: [[SimpleTest]]: [MySQL] 54,838 pass(es). View
#4 drupal-1975114-4.patch52.67 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed. View
#1 1975114-menu_default_state-cmi-drupal-1.patch816 bytesACF
PASSED: [[SimpleTest]]: [MySQL] 54,473 pass(es). View

Comments

ACF’s picture

Status: Active » Needs review
FileSize
816 bytes
PASSED: [[SimpleTest]]: [MySQL] 54,473 pass(es). View
catch’s picture

Title: Change menu_default_node_menu to state. » Views references menu_default_node_menu variable which doesn't exist anywhere else
Component: configuration system » views.module
Category: task » bug
Issue tags: +VDC

This looks like a reference to a core variable, but the core variable doesn't exist at all/any more. Moving to views - maybe someone working on VDC knows what this was trying to do.

longwave’s picture

git pickaxe shows this was removed from core during the 6>7 upgrade cycle in #716792: Remove 'Default menu for content' setting from structure>menus>settings.. This core variable is now set per content type, so there seems to be no useful replacement?

This bug should also be raised against Views 7.x-3.x.

dawehner’s picture

FileSize
52.67 KB
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed. View

So we can't provide anything more useful than navigation.

Status: Needs review » Needs work

The last submitted patch, drupal-1975114-4.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
FileSize
774 bytes
PASSED: [[SimpleTest]]: [MySQL] 54,838 pass(es). View

Ups, this patch was way too big :)

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

:)

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed a389298 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.