Register test module classes to PHPunit [#1974266]

Sometimes test classes from test modules are needed in PHPunit tests, like eg test Plugins.
Right now though test module classes are not registered in bootstrap.php
Patch coming

Comment	File	Size	Author
#13	drupal-test_modules_lib_phpunit-1974266-13.patch	2.3 KB	ParisLiakos
#13
#11	drupal-test_modules_lib_phpunit-1974266-11.patch	2.3 KB	ParisLiakos
#11
#9	drupal-test_modules_lib_phpunit-1974266-9.patch	2.29 KB	ParisLiakos
#9
#9	interdiff.txt	776 bytes	ParisLiakos
#7	drupal-test_modules_lib_phpunit-1974266-7--FAIL.patch	1.59 KB	ParisLiakos
#7
#7	drupal-test_modules_lib_phpunit-1974266-7.patch	2.25 KB	ParisLiakos
#7
#3	drupal-phpunit_test_classes-1974266-3.patch	672 bytes	ParisLiakos
#3
#2	drupal-phpunit_test_classes-1974266-2.patch	695 bytes	ParisLiakos
#2
#1	drupal-phpunit_test_classes-1974266-1.patch	606 bytes	ParisLiakos
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

ParisLiakos CreditAttribution: ParisLiakos commented 18 April 2013 at 22:46

Status:

Active

» Needs review

File	Size
drupal-phpunit_test_classes-1974266-1.patch	606 bytes

Comment #2

ParisLiakos CreditAttribution: ParisLiakos commented 18 April 2013 at 23:00

File	Size
drupal-phpunit_test_classes-1974266-2.patch	695 bytes

Actually we need a check first, not all modules have this folder

Comment #3

ParisLiakos CreditAttribution: ParisLiakos commented 18 April 2013 at 23:02

File	Size
drupal-phpunit_test_classes-1974266-3.patch	672 bytes

hrmmm better patch

Comment #4

dawehner

German

CreditAttribution: dawehner commented 22 April 2013 at 12:48

Status:

Needs review

» Reviewed & tested by the community

Perfect!

Comment #5

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 22 April 2013 at 18:32

Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+Needs tests

I think we should be adding a test here to prove we can now load test classes from test modules in PHPUnit tests....

Comment #6

ParisLiakos CreditAttribution: ParisLiakos commented 22 April 2013 at 19:30

@alexpott: i already have a test that fails without this here.this issue kinda waits for this one
#1957330-25: Make possible for parsers and fetchers to expose configuration through plugins
What about closing this and commit this there?

Comment #7

ParisLiakos CreditAttribution: ParisLiakos commented 23 April 2013 at 00:10

Status:	Needs work	» Needs review
Issue tags:	-Needs tests

File	Size
drupal-test_modules_lib_phpunit-1974266-7.patch	2.25 KB

drupal-test_modules_lib_phpunit-1974266-7--FAIL.patch	1.59 KB

nevermind, here is a specific test

Comment #8

dawehner

German

CreditAttribution: dawehner commented 23 April 2013 at 07:50

I like the simplicity of the test

+++ b/core/modules/simpletest/tests/Drupal/simpletest/Tests/PhpUnitAutoloaderTest.phpundefined
@@ -0,0 +1,32 @@
+    $this->assertTrue(class_exists('\Drupal\phpunit_test\PhpUnitTestDummyClass'));

It could be helpful to provide a custom message.

Comment #9

ParisLiakos CreditAttribution: ParisLiakos commented 23 April 2013 at 08:41

File	Size
interdiff.txt	776 bytes
drupal-test_modules_lib_phpunit-1974266-9.patch	2.29 KB

true, here it is

Comment #10

dawehner

German

CreditAttribution: dawehner commented 23 April 2013 at 17:58

+++ b/core/modules/simpletest/tests/Drupal/simpletest/Tests/PhpUnitAutoloaderTest.phpundefined
@@ -26,7 +26,7 @@ public static function getInfo() {
+    $this->assertTrue(class_exists('\Drupal\phpunit_test\PhpUnitTestDummyClass'), 'Class provided by test module was not loaded');

Was not loaded? Additional there is a missing "." at the end.

Comment #11

ParisLiakos CreditAttribution: ParisLiakos commented 23 April 2013 at 20:02

File	Size
drupal-test_modules_lib_phpunit-1974266-11.patch	2.3 KB

Edited it manually:

loaded => autoloaded
added dot

Comment #12

dawehner

German

CreditAttribution: dawehner commented 23 April 2013 at 21:03

+++ b/core/modules/simpletest/tests/Drupal/simpletest/Tests/PhpUnitAutoloaderTest.phpundefined
@@ -0,0 +1,32 @@
+    $this->assertTrue(class_exists('\Drupal\phpunit_test\PhpUnitTestDummyClass'), 'Class provided by test module was not autoloaded.');

+++ b/core/tests/bootstrap.phpundefined
@@ -8,6 +8,13 @@
+  $test_modules_dir = __DIR__ . "/../modules/$module/tests/modules";
...
+      $loader->add('Drupal\\' . $test_module, $test_modules_dir . '/' . $test_module . "/lib");

We can use '' instead of "" here.