I discovered this while testing out Spark for the first time. I wanted to see how the new features held up without Panels, out of curiosity - so I disabled all the Panels modules that were turned on, then went to the homepage. Only to find:

Fatal error: Class 'panels_display' not found in /Users/erica/repos/spark/profiles/spark/modules/spark_demo/spark_demo.module on line 205

I shouldn't have been able to do that so easily. Turns out the Spark Demo module only lists every_field as a dependency, which populates most needed dependencies down the chain of modules Every Field requires, but Panels/Panels IPE don't get mentioned by any of them. Panels should be added as a dependency in spark_demo.info so that Panels cannot be disabled while Spark Demo is enabled.

Minor problem, really, but we want Spark to look good to new users and be easily testable. I will add a patch in a bit.

Members fund testing for the Drupal project. Drupal Association Learn more


irk’s picture

Status: Active » Needs review
352 bytes

I hope I did this right because it's my first patch!

irk’s picture

Actually this doesn't solve the whole problem - Panels In-Place Editor needs to be the dependency, because I can still disable that and break Spark Demo. I'll update with a new patch in a few minutes.

On second check Spark Demo wasn't breaking without Panels IPE. An unrelated issue caused me to come to that conclusion. The first patch should be used, not the second.

irk’s picture

Added Panels IPE as the dependency.

Actually it looks like Panels IPE doesn't need to be enabled for Spark Demo to work, just Panels. So the first patch should be used, not this one.

irk’s picture

Issue summary: View changes

Added Panels IPE details to the summary.

Gábor Hojtsy’s picture

Status: Needs review » Fixed

That is a very good point. Committed and pushed that, it should be out with the next release. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Removed Panels IPE from summary as it seems to be irrelevant.