1) using .prop() to toggle the 'open' attribute fails on browser not supporting the details element. There are CSS rules relying on it that are not properly triggered. Switched back to using .attr() which works for everyone.

2) Vtabs are not fieldsets anymore. so the settings.fieldset.attr() call was broken.

Patch fixes both.

CommentFileSizeAuthor
core-js-oups-i-did-it-again-broken-vtab.patch981 bytesnod_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

swentel’s picture

swentel CreditAttribution: swentel commented

Yup, that fixes it, let's wait for another confirmation.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Active » Needs review
echoz’s picture

echoz CreditAttribution: echoz commented

Patch for 2) is duplicated over here #1971118: Stray reference to fieldset in vertical-tabs.js that was not updated to details. Mark that as dupe (even though it was first), or separate the 2 fixes?

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Reviewed & tested by the community

It ends up the same. Let's just commit this one with credits from the other one too.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed d2e5e7b and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.