SKU is not a Field API field AFAIK... but it would be super cool if this module supported it..

CommentFileSizeAuthor
#5 editableviews-commerce_sku_support-1972954-5.patch5.86 KBtmsimont
#2 editableviews-commerce_sku_support-1972954-2.patch4.61 KBtmsimont
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim’s picture

joachim CreditAttribution: joachim commented

Agreed.

Patch welcome! :)

tmsimont’s picture

tmsimont CreditAttribution: tmsimont commented
FileSize
editableviews-commerce_sku_support-1972954-2.patch4.61 KB

easier than i thought it would be!

nice module.

tmsimont’s picture

tmsimont CreditAttribution: tmsimont commented
Status: Active » Needs review
joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Needs work

Glad to hear it!

Just needs a few tweaks. Remember to trim whitespace off the end of lines before you roll a patch too.

+++ b/editableviews.views.inc
@@ -83,6 +83,18 @@ function editableviews_views_data_alter(&$data) {
+  // CommerceProduct sku editable field.
+  $data['commerce_product']['sku_editable'] = array(

This should check whether commerce_product module is present (or whether the table is in $data, which is easier and tantamount to the same thing).

+++ b/handlers/editableviews_handler_field_commerce_product_sku_edit.inc
@@ -0,0 +1,72 @@
+ * Field handler for node title editable field.

!! ;)

tmsimont’s picture

tmsimont CreditAttribution: tmsimont commented
FileSize
editableviews-commerce_sku_support-1972954-5.patch5.86 KB

sorry bout the whitespace... i have a deadline in a few hours here working in warp speed -- this ones got the same problems, but i noticed an issue on ln 176 of editableviews_plugin_style_row_edit_table.inc -- this should take care of that i can clean this up in a few days if u dont want to

rollingnet’s picture

rollingnet CreditAttribution: rollingnet commented
Issue summary: View changes

The SKU support would be great, if it worked!

I apply the patch, but i get this error
EntityMalformedException: Missing bundle property on entity of type commerce_product. in entity_extract_ids() (line 7721 of /includes/common.inc).

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs work » Closed (duplicate)

Should work with #2090731: add a handler for generic Entity API metadata properties.