There just isn't enough of a difference between the unfocused state & focused state of the pencils:
Pencil hover state lacks contrast

Can we modify this so that we have a slightly darker edit-focus.png image?

.contextual .trigger {
    background-attachment: scroll;
    background-color: #FFFFFF;
    background-image: url("../../misc/edit.png");

I think this would also be useful for mouse overs.

CommentFileSizeAuthor
#4 Screen Shot 2013-11-14 at 9.03.11 AM.png12.99 KBmgifford
#3 pencil_hover-1972872-3.patch1.06 KBWim Leers
Pencil-hover-state.png19.42 KBmgifford
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented

Agreed, however I really dislike our lets make it dark gray approach. I will take it up with the style guide, which should provide outcome to all focus states of buttons

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

Sounds brilliant.. Ya grey is boring.. Thanks Bojhan.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Category: Bug report » Task
Priority: Normal » Minor
Issue summary: View changes
Status: Active » Needs review
FileSize
pencil_hover-1972872-3.patch1.06 KB

What about this?

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Needs review » Reviewed & tested by the community
FileSize
Screen Shot 2013-11-14 at 9.03.11 AM.png12.99 KB

This looks great. Here's a pencil with focus and without focus. Works fine with keyboard and also with the mouse.

Thanks Wim.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Issue tags: +Spark

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.