File URL to original image broken [#1971696]

When changing the Normal image style from flexslider_full to None (original image) the file path is wrong and no images show up.

File path ends up being:

http://domain/sites/default/files/styles/public/file.jpg

Instead of:

http://domain/sites/default/files/file.jpg

Comment	File	Size	Author
#4	flexslider-original_image_path_fix-1971696-7434066.patch	1.46 KB	piyuesh23
#4
#2	flexslider-original_image_path_fix-1971696-7434042.patch	1.15 KB	piyuesh23
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

piyuesh23 CreditAttribution: piyuesh23 commented 21 May 2013 at 05:43

Assigned:

Unassigned

» piyuesh23

Comment #2

piyuesh23 CreditAttribution: piyuesh23 commented 21 May 2013 at 05:52

File	Size
flexslider-original_image_path_fix-1971696-7434042.patch	1.15 KB

There is no condition set to handle the original image case. Attaching a patch for this fix.

Comment #3

piyuesh23 CreditAttribution: piyuesh23 commented 21 May 2013 at 05:52

Status:

Active

» Needs review

Comment #4

piyuesh23 CreditAttribution: piyuesh23 commented 21 May 2013 at 06:09

File	Size
flexslider-original_image_path_fix-1971696-7434066.patch	1.46 KB

Adding another patch with couple of warnings fixed for the original image.

Comment #5

caktux CreditAttribution: caktux commented 29 May 2013 at 18:36

Works great, the patch just needs to be based in the module's folder and not Drupal's root.

Comment #6

ThaJoa CreditAttribution: ThaJoa commented 4 June 2013 at 11:39

The patch shows the images now but it still ignores the original image style, it keeps showing it as flexslider_full

Comment #7

minorOffense CreditAttribution: minorOffense commented 8 June 2013 at 14:58

Status:

Needs review

» Closed (fixed)

I've committed the code to dev. I think the image style selection is another issue in the queue.

Once I have that code fixed too, we can revisit this one to ensure it's all working.

As for the path to the image, that should be set by the file ID itself. I don't see anything in here which is forcing it to be in a certain path (but I could be wrong).