This loops through each breakpoint, and runs entity_load() on it. We have entity_load_multiple() for a reason.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

Status: Active » Needs review
FileSize
1.55 KB

The protected method is overkill anyway, I'd say.

tim.plunkett’s picture

FileSize
4.06 KB

Okay, here's a full overhaul of this. I felt weird writing that in the __construct, so I had to go ahead and fix all of it.

Status: Needs review » Needs work

The last submitted patch, breakpoint-1971174-2.patch, failed testing.

subson’s picture

Assigned: Unassigned » subson

In progress... Drupalcon sprint, May 24, 2013

subson’s picture

Status: Needs work » Needs review
FileSize
4.02 KB

re-rolling the patch.

Status: Needs review » Needs work
Issue tags: -Quick fix

The last submitted patch, breakpoint-1971174-5.patch, failed testing.

Berdir’s picture

Status: Needs work » Needs review

#5: breakpoint-1971174-5.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, breakpoint-1971174-5.patch, failed testing.

subson’s picture

Status: Needs work » Needs review

#5: breakpoint-1971174-5.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Quick fix

The last submitted patch, breakpoint-1971174-5.patch, failed testing.

tim.plunkett’s picture

Title: BreakpointGroup::loadAllBreakpoints() is extremely expensive » BreakpointGroup::loadAllBreakpoints() is expensive
Status: Needs work » Needs review
FileSize
4.65 KB

Rerolled, adapted for modern approaches.

The last submitted patch, breakpoint-1971174-11.patch, failed testing.

Jelle_S’s picture

Issue summary: View changes

I think we can close this since this method got removed when #1851018: Improve breakpoint configuration implementation. was fixed?
(setting to NR so someone can review this comment and confirm that this is in fact fixed, won't fix, or an other similar status)

Jelle_S’s picture

Status: Needs work » Needs review

Strange, I really thought I'd set this to NR :-/

RainbowArray’s picture

As @Jelle_S mentioned, this can probably be closed due to #1851018: Improve breakpoint configuration implementation., right?

attiks’s picture

Status: Needs review » Closed (won't fix)