Lets simplify this text a little, I think the word "skip" is much more accessible than offset so I made it part of the label.

Before

items-to-display-and-offset-before.png

After

pager-options-after.png

CommentFileSizeAuthor
#9 simplify-pager-options-help-descriptions-1970060-9.patch3.27 KBDrupalChimp
#6 simplify,pager.option.descriptions.patch3.26 KBBojhan
pager.offset.helptext.patch3.31 KBBojhan
pager-options-after.png238.85 KBBojhan
items-to-display-and-offset-before.png268.47 KBBojhan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

oresh’s picture

oresh CreditAttribution: oresh commented

In the 'items to skip' you removed word 'field' and replaced with: if this is set to 3.
Can we move the field back, or remove 'this is' word: 'if set to 3' ?
It just sounds strange to me.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented

@oresh We might need to rephrase it altogether. I think its weird to reference "field", as people might think it refers to the concept of "fields" while instead we use it to reference the textfield above.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

I like the new strings, but feel free to discuss the best solution.

yoroy’s picture

yoroy CreditAttribution: yoroy commented

I think the label is good. For the description maybe:

For example, set this to 3 and the first 3 items will not be displayed.
Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
Issue tags: +Novice

@oresh Lets do this, could you reroll with yoroy his suggestion?

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
FileSize
simplify,pager.option.descriptions.patch3.26 KB

With the revision suggested by yoroy

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

This is looking perfect. It's great to cleanup the UI on so many places.

DrupalChimp’s picture

DrupalChimp CreditAttribution: DrupalChimp commented

Agreed, this latest patch works as expected including text in post #4

DrupalChimp’s picture

DrupalChimp CreditAttribution: DrupalChimp commented
Status: Reviewed & tested by the community » Needs review
FileSize
simplify-pager-options-help-descriptions-1970060-9.patch3.27 KB

Actually there was a missing closing bracket in Some.php causing the text to read

Offset (number of items to skip

now set to

Offset (number of items to skip)

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
Status: Needs review » Reviewed & tested by the community

That sounds ok to me

oresh’s picture

oresh CreditAttribution: oresh commented

Works fine for the latest build, no grammar mistakes, description is clear and short.
+1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 624947f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.