Perhaps this should follow the same model as proposed for contextual links but at the very least we shouldn't have a yes/no radio here.

CommentFileSizeAuthor
#2 hide.attachments.png193.51 KBBojhan
remove.yes_.no_.attachments.patch933 bytesBojhan
checkbox_hide.png175.54 KBBojhan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Active » Needs review
Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
FileSize
hide.attachments.png193.51 KB

hide.attachments.png

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs review » Reviewed & tested by the community

Looks good!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs review

Can someone confirm they tested this manually and the checkbox still works? I'm not 100% sure we can just switch data types so easily and FAPI just sucks it up, and I'm not sure how robust our test coverage is for this area of Views.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Issue tags: +Needs manual testing

Tagging.

Otherwise? Looks good!

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing

It's indeed easier to understand, as you don't have to look at the title in order to set the setting.

In general this setting is quite advanced, so in theory a description would maybe helpful?

Manual testing: (the setting in the UI didn't changed) and the config didn't changed at all, after saving before and after the patch.

Before:

          override: '1'
          sticky: '0'
      hide_attachment_summary: '1'
  page_1:
    id: page_1
    display_title: Page

After:

          override: '1'
          sticky: '0'
      hide_attachment_summary: '1'
  page_1:
    id: page_1
    display_title:
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Great, thanks!

Committed and pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.