Reported at #1962190: In-place editing toolbars in DOM not removed after stopping in-place editing (was: Tidy up HTML after toggling Quick Edit) for D7 version of Edit module, since D7/D8 Edit's JS is >95% identical, the same bug exists in D8.

If you start quick editing, stop it, start it, stop it, etc. for a certain entity, then you will notice that Edit doesn't properly clean up after itself:

This was introduced in the last big refactoring; the toolbars are now persisted for the entire duration of the in-place editing process. Previously, they were continuously created and removed upon hover/editing, which results in many more DOM operations, and is thus slower.

CommentFileSizeAuthor
#1 edit_toolbar_cleanup-1967728-1.patch1.88 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Status: Active » Needs review
FileSize
1.88 KB

The fix is: remove code that is no longer necessary :)

Note: this is a straight port of the fix for D7 Edit, that got committed at #1962190-5: In-place editing toolbars in DOM not removed after stopping in-place editing (was: Tidy up HTML after toggling Quick Edit).

dmsmidt’s picture

Status: Needs review » Reviewed & tested by the community

Tested. Patch did the job.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Well, never going to argue with less code. :D

Committed and pushed to 8.x. Thanks!

Wim Leers’s picture

Issue tags: -sprint

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Attempt to fix image link.