Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hey everyone,
Earlier today I installed AIS, and so far it's working exactly the way I expected it to. There is however one thing that does pop up every once in a while - a PHP Strict Warning. As far as I can tell, this doesn't impede functioning in any way, but I thought I'd drop it here anyway.
Strict warning: Only variables should be passed by reference in ais_image_style_deliver() (line 107 of C:\Documents and Settings\PixelSmash\My Documents\xampp\htdocs\pixelsmash\sites\all\modules\contrib\ais\ais.module).
Comment | File | Size | Author |
---|---|---|---|
#1 | ais-strict-warning-1967688-1.patch | 952 bytes | pixelsmash |
Comments
Comment #1
pixelsmash CreditAttribution: pixelsmash commentedCreated a small patch that should fix the issue. Hope it works, since it's the first time I've created a patch - so apologies in advance if I make a mistake. In short: create a variable for
variable_get('ais_adaptive_styles', array())
first, then use that in the call to_ais_is_used
. (As opposed to using the variable_get straight away in _ais_is_used, the way it is now)Comment #2
pixelsmash CreditAttribution: pixelsmash commentedComment #3
stevieegee CreditAttribution: stevieegee commentedI don't understand the intricacies of php code but the patch worked for me! Thank you.
Comment #4
spotzero CreditAttribution: spotzero commentedLooks good. Committed to dev branch.
Comment #6
jeffpurtle CreditAttribution: jeffpurtle commentedI'm getting this error too and I have the latest version of AIS.
Comment #7
pixelsmash CreditAttribution: pixelsmash commentedjeff, as far as I can tell the patch was committed to the dev branch, but not (yet) to the stable release. 7.x-1.6 stable was updated before I even opened this issue.
Comment #8
thomas.claes CreditAttribution: thomas.claes commentedWhen will the patched version be commited to the stable branch?
Comment #9
doitDave CreditAttribution: doitDave commentedI would like to see this in a branch considered stable before it is considered "fixed", since few would like to have a "dev" branch snapshot in a prod env. Would be nice if we could see a new release. Thanks!
Edit: Confirmed working, no side-effects detected, original issue is solved by this.
Comment #10
spotzero CreditAttribution: spotzero at Coldfront Labs Inc. commentedI've pushed a release. 7.x-1.7 should be available soon.
Comment #11
doitDave CreditAttribution: doitDave commentedGreat! Thank you!