Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
In #1849752: Abstract non-Drupal-specific parts of AnnotatedClassDiscovery into a Drupal\Component base class, AnnotatedClassDiscovery was split in two.
However, now that #1966246: [meta] Introduce specific annotations for each plugin type is starting to extend Core\AnnotatedClassDiscovery, it's evident that a custom Discovery class needs access to all 3 parameters from Component\AnnotatedClassDiscovery.
Comment | File | Size | Author |
---|---|---|---|
#9 | annotation-1967420-9.patch | 8.54 KB | tim.plunkett |
#9 | interdiff.txt | 1.52 KB | tim.plunkett |
#7 | drupal-1967420-7.patch | 8.78 KB | dawehner |
#1 | plugin-1967420-1.patch | 1.42 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettComment #2
tim.plunkettTagging
Comment #3
EclipseGc CreditAttribution: EclipseGc commentedThis looks totally reasonable to me.
Eclipse
Comment #4
tim.plunkettLost the tag.
Comment #5
dawehnerWhat about adding a test coverage?
Comment #6
tim.plunkettI tried to type out "we don't need tests" but I couldn't do it :)
Also going to fix the docblocks.
Comment #7
dawehnerAdded a test.
Comment #8
tim.plunkettTypo, Example
One has a / before core, the other doesn't.
Comment #9
tim.plunkettAh! That explains the include_once.
Thanks so much @dawehner! This should be done now.
Comment #10
EclipseGc CreditAttribution: EclipseGc commentedcool by me!
Comment #11
webchickCommitted and pushed to 8.x. Thanks!