When you switch to manual entry mode, it's a little jarring to have a fieldset suddenly appear that surrounds the textarea input, whereas the options element selection did not have any fieldset around it. I think it should just use a container.

Members fund testing for the Drupal project. Drupal Association Learn more


Dave Reid’s picture

Status: Active » Needs review
1.11 KB

Patch against 7.x-1.8.

quicksketch’s picture

Thanks @DaveReid! I think you're right. We're only using a fieldset because 'container' didn't exist in D7. We can use a more specific selector for just div.options, the current double-selector for fieldsets is a side-effect of #902474: Not compatible with Admin module or Rubik admin theme.

Dave Reid’s picture

Ok so it sounds like we might need to adjust the selector to just use 'div.options' then, which should be universally supported since we'd no longer be using fieldsets.

Dave Reid’s picture

Version: 7.x-1.8 » 7.x-1.x-dev
Status: Needs review » Fixed

Adjusted the JS selection to use div.options and committed to 7.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.