Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
When you switch to manual entry mode, it's a little jarring to have a fieldset suddenly appear that surrounds the textarea input, whereas the options element selection did not have any fieldset around it. I think it should just use a container.
Comment | File | Size | Author |
---|---|---|---|
#1 | 1966852-manual-entry-container-not-fieldset.patch | 1.11 KB | Dave Reid |
Comments
Comment #1
Dave ReidPatch against 7.x-1.8.
Comment #2
quicksketchThanks @DaveReid! I think you're right. We're only using a fieldset because 'container' didn't exist in D7. We can use a more specific selector for just div.options, the current double-selector for fieldsets is a side-effect of #902474: Not compatible with Admin module or Rubik admin theme.
Comment #3
Dave ReidOk so it sounds like we might need to adjust the selector to just use 'div.options' then, which should be universally supported since we'd no longer be using fieldsets.
Comment #4
Dave ReidAdjusted the JS selection to use div.options and committed to 7.x-1.x. Thanks!
http://drupalcode.org/project/options_element.git/commit/00bd3e3