Allow user fields to be saved during registration from slave [#1966826]

Problem/Motivation

If someone attempts to register on a slave site (i.e. no user account on the master either), then the only form values passed to the master are the four in $allowed = array('name', 'mail', 'pass', 'timezone');. The end result is the user account on each site omits all other values submitted on registration. So, if a user wants to update their account, e.g. to set the password after using the one-time login link, then they need to re-enter all of the form values included on registration. On each site, potentially.

This practice seems a bit self-defeating in light of issues like #556666: Sync hooks: Enable sharing of arbitrary data dealing with data syncing to the slave sites when user account is updated on the master.

Proposed resolution

Allow all form values to be sent to the master AND to be returned to the slave (if the slave requires email validation so that an account will also be established on the slave)? The form values will automatically be included in the calls to user_save().

Remaining tasks

Review, write tests, update documentation.

User interface changes

None, except that registration form values will show up on each site when viewing a user account.

API changes

None.

#1954462: Support extra query arguments along with query destination and during registration
- this adds a special exception to send and return the query argument in the oatmeal cookie
- this seems very similar to sending all the form values on registration, as proposed here
#556666: Sync hooks: Enable sharing of arbitrary data

Comment	File	Size	Author
#5	bakery-slave_registration_supported_fields-1966826-5.patch	1.44 KB	caschbre
#4	bakery-slave_registration_supported_fields-1966826-4.patch	1.37 KB	caschbre
#3	bakery-slave_registration_supported_fields-1966826-3.patch	1.32 KB	caschbre
#2	1966826-allow-user-fields.patch	2.63 KB	solotandem
#1	1966826-allow-user-fields.patch	2.49 KB	solotandem

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

solotandem CreditAttribution: solotandem commented 10 April 2013 at 16:40

Status:

Active

» Needs review

File	Size
1966826-allow-user-fields.patch	2.49 KB

Patch implements proposed resolution and also fixes some whitespace issues.

In bakery_register_return(), setting of $new could be changed to match style used in bakery_register() which sets individual items in the $userinfo array instead of all at once. For example:

  $userinfo['name'] = $name;
  $userinfo['mail'] = $mail;

as opposed to:

$new += array(
  'name' => $cookie['name'],
  'mail' => $cookie['data']['mail'],
);

Comment #2

solotandem CreditAttribution: solotandem commented 11 April 2013 at 16:20

File	Size
1966826-allow-user-fields.patch	2.63 KB

Patch in #1 leaves the uid from master in the cookie returned to slave. This means slave tries to save user with the same uid, which may fail.

Attached patch fixes this.

Comment #2.0

solotandem CreditAttribution: solotandem commented 11 April 2013 at 16:20

Issue summary:

View changes

Rephrase and reorganize.

Comment #3

caschbre CreditAttribution: caschbre commented 6 June 2014 at 21:26

File	Size
bakery-slave_registration_supported_fields-1966826-3.patch	1.32 KB

I'm working on a project where we want similar functionality, however we don't want to pass just anything on the registration form. Attached is a patch that filters based on the supported fields.