Enabling/disabling aggregator plugins doesnt make a lot sense at all on a global state
Contrib could really use bundles, and core would make it easier.

And the thing is that its not hard at all to make this possible, patch size is suprisingly small so far!

CommentFileSizeAuthor
#5 drupal-aggregator-bundles-1966070-5.patch30.65 KBtwistor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented

http://drupal.org/node/15266#comment-7244712 contains some of the code, i ll try to split it from this patch and post it here..or if anyone else is interested

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Title: Make aggregator feeds bundleable - move opml functionality to a new bundle and plugin configuratiuon per bundle » Make aggregator feeds bundleable - move opml functionality to a new bundle and plugin configuration per bundle

also not quite sure whether this is feature or task..but it certainly makes sense having OPML as bundles rather than a hacky custom solution..
still have to figure out what to do though with the feed properties

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Title: Make aggregator feeds bundleable - move opml functionality to a new bundle and plugin configuration per bundle » Make aggregator feeds bundleable - move plugins configuration per bundle
Category: task » feature

actually, no lets keep OPML out of this, it is not an actual feed, its data never stored in db, it just creates new feeds with some temp data

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Issue summary: View changes

Keep OPML out of this

twistor’s picture

twistor CreditAttribution: twistor commented

#1963540: Move OPML parsing login in OpmlFeedAdd to a parser plugin depends on this is. If you try to make the opml parser a plugin, then it's exposed in the UI, and you need this.

We should just ship with a default bundle that handles the opml case.

Plus, it's perfectly reasonable to want to ping an opml file and create feeds out of it. Or nodes, from a CSV :)

twistor’s picture

twistor CreditAttribution: twistor commented
Assigned: Unassigned » twistor
Status: Active » Needs work
FileSize
drupal-aggregator-bundles-1966070-5.patch30.65 KB

First go at moving the code over from http://drupal.org/node/15266#comment-7244712.

This is still pretty rough.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented 
+++ b/core/modules/aggregator/aggregator.admin.incundefined
@@ -44,7 +44,7 @@ function aggregator_view() {
-      'href' => "admin/config/services/aggregator/edit/feed/$feed->fid",
+      'href' => "aggregator/sources/$feed->fid/edit",

needs hook_admin_path()

+++ b/core/modules/aggregator/aggregator.moduleundefined
@@ -89,6 +89,37 @@ function aggregator_theme() {
+    'type' => MENU_LOCAL_ACTION,
+    'weight' => 1,

probably better to use default - 1 makes no sense

+++ b/core/modules/aggregator/aggregator.moduleundefined
@@ -89,6 +89,37 @@ function aggregator_theme() {
+    'type' => MENU_DEFAULT_LOCAL_TASK,
+    'weight' => -10,

default does not need weight

+++ b/core/modules/aggregator/lib/Drupal/aggregator/FeedTypeListController.phpundefined
@@ -0,0 +1,63 @@
+    $row['type'] = t('Feed type');
+    $row['description'] = t('Description');
+    $row['operations'] = t('Operations');

Please use parent::buildHeaded() and unset() unused

+++ b/core/modules/aggregator/lib/Drupal/aggregator/FeedTypeStorageController.phpundefined
@@ -0,0 +1,44 @@
+      entity_invoke_bundle_hook('create', 'aggregator_feed', $entity->id());
+      // aggregator_add_category_field('aggregator_feed', $entity->id());

needs cleanup

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes

Better issue summary

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Issue summary: View changes
Issue tags: +Needs reroll
Related issues: +#1963540: Move OPML parsing login in OpmlFeedAdd to a parser plugin

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

vacho’s picture

vacho CreditAttribution: vacho at Skilld commented

More that convert Aggregator as bundleable is better treat this requirement-feature as taxonomyable
This issue is about it.
https://www.drupal.org/node/15266
I think that is better close this task

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Project: Drupal core » Aggregator
Version: 9.3.x-dev » 1.x-dev
Component: aggregator.module » Code

The aggregator module has been removed from Core in 10.0.x-dev and now lives on as a contrib module. Issues in the Core queue about the aggregator module, like this one, have been moved to the contrib module queue.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Priority: Normal » Major
Issue tags: +Aggregator 2.x