Since the tests setup their own namespace injection for Condition plugins instead of using the DIC, the conditions continued to work, but the DIC registered plugin manager actually fails currently.

Eclipse

CommentFileSizeAuthor
#1 1965836-1.patch1.36 KBEclipseGc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
Status: Active » Needs review
FileSize
1965836-1.patch1.36 KB

This is a really minimal change to just fix what I'd currently call a bug. It'll also help smooth along the other condition plugin patches I'm working on.

Eclipse

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

Wow. This can't "need tests", because that was the test. When the namespaces needed to be passed to the manager, someone went out of their way to hack them in...

So yes, this is the correct fix.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue tags: +Quick fix

This will block the other condition issues, let's just get this in.

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
Priority: Normal » Major

per xjm's suggestion.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed bf06e18 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.