Problem/Motivation

Install can happen in another language now. And some config, like the site name, is saved during install. If I'm installing in Spanish and I name my site: Azul. I would not expect to be able to translate the site name into Spanish... I would assume it's already in spanish, and not saved as english.

Proposed resolution

That should be saved with the langcode of the language being installed.

Steps to reproduce

http://drupal.org/project/config_translation is handy.

Remaining tasks

(done) manual testing

User interface changes

No UI changes.

API changes

No API changes.

CommentFileSizeAuthor
#1 install-site-info-langcode.patch499 bytesGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Active » Needs review
FileSize
install-site-info-langcode.patch499 bytes

This should be a 1-line fix IMHO, where the config is saved from the installer, a langcode should also be specified. It is not currently possible to test the installer, so no way to write tests for this. See #630446: Allow SimpleTest to test the non-interactive installer. So I think this should be manually tested and verified.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: +Quick fix, +sprint
YesCT’s picture

YesCT CreditAttribution: YesCT commented
Status: Needs review » Reviewed & tested by the community

manually tested and verified.

first with no special language, so just english in the the install. langcode: en is saved in system.site.yml

then with a language (af) chosen in the install. langcode: af saved in the system.site.yml

also tried out the config translation for that, and behavior is as expected (adding a translation to af is not an option. which is good, it's already af!)

#1942168: Make System module active config save format match the default yml file. should take care of also adding it to the system default config yml

this issue reminded us to: #1964254: Configuration schemas missing langcode and uuid at places

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

I added this to the very-much-incomplete list of issues to add test coverage for in #1961938: Test the interactive installer.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 879589c and pushed to 8.x. Thanks!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: -sprint

Superb, thanks!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Thanks again! (and removing sprint tag again :)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.