Convert aggregator_form_opml to a FormInterface implementation and routing definition

Hi, thanks for picking this up!

Looks good so far, some notes:

+++ b/core/modules/aggregator/aggregator.routing.ymlundefined
@@ -4,3 +4,10 @@ aggregator_feed_items_delete:
+add_opml:

lets call the route aggregator_opml_add so it is consistent with the rest routes there and also correctly prefixed

+++ b/core/modules/aggregator/aggregator.routing.ymlundefined
@@ -4,3 +4,10 @@ aggregator_feed_items_delete:
+    _content: '\Drupal\aggregator\Form\FeedAddOpml'

it should be _form and lets call the class OpmlAdd or OpmlFeedAdd so its inline with FeedItemsDelete )verb last)

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Form/FeedAddOpml.phpundefined
@@ -0,0 +1,172 @@
+      $response = drupal_http_request($form_state['values']['remote']);

this is being converted to guzzle on #1862524: Convert drupal_http_request usage in aggregator.module to Guzzle so when it is in (rtbc now) we can inject guzzle as well:)

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Form/FeedAddOpml.phpundefined
@@ -0,0 +1,172 @@
+    $feeds = _aggregator_parse_opml($data);

opened #1963540: Move OPML parsing login in OpmlFeedAdd to a parser plugin for this, so we can inject this too, you can leave it as is for now:)

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Form/FeedAddOpml.phpundefined
@@ -0,0 +1,172 @@
+      $result = db_query("SELECT title, url FROM {aggregator_feed} WHERE title = :title OR url = :url", array(':title' => $feed['title'], ':url' => $feed['url']));

should get rid of db_query and use $this->database->query instead

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Form/FeedAddOpml.phpundefined
@@ -0,0 +1,172 @@
+      $new_feed = entity_create('aggregator_feed', array(

Instead of using entity_create here, lets inject the entity manager and do what http://api.drupal.org/api/drupal/core!includes!entity.inc/function/entit... does:) get the storage and call create on it

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Form/FeedAddOpml.phpundefined
@@ -0,0 +1,172 @@
+            'title' => $feed['title'],
+            'url' => $feed['url'],
+            'refresh' => $form_state['values']['refresh'],
+            'block' => $form_state['values']['block'],
+            ));

indentation is off

the guzzle patch just committed so together with entity manager they should now be injected in the class

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Form/OpmlFeedAdd.phpundefined
@@ -0,0 +1,174 @@
+      $new_feed = drupal_container()->get('plugin.manager.entity')

Not what i meant above.the plugin manager entity should be passed in the __construct with database, and should be stored in $this->entityManager..then no need to use drupal_container()

great! entity plugin manager is injected now:)

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Form/OpmlFeedAdd.phpundefined
@@ -0,0 +1,198 @@
+        $response = Drupal::httpClient()

This should be injected as well, together with database and entity manager:)
it should be stored in $this->httpClient

yeah but i am not really sure whether #1966070: Make aggregator feeds bundleable - move plugins configuration per bundle makes it in d8, so this is a really good step

yes this looks great now, thanks
not sure why tests fail though, i should check manually once i find some time

tests failed because _aggregator_parse_opml was in the admin.inc which was not loaded.
I moved it to a protected method to the controller with a todo above it.
Also injected the entityQuery and converted a query to use it instead:)

rerolled for conflict with multiple uploader patch, yay:)

uhm, wrong patch above, does not contain the addition in file_save_upload in the Controller

reroll for #1972262: Convert aggregator_feed_add to a new style controller