Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I found this by accident, as the regular CSS obfuscates the error – even empty popup wrappers get a close button element by the module script.
I turned off the module CSS file out of performance and simplicity reasons and now the popup close button is attached to the empty popup wrapper on every search box even though it's not used.
Would it be possible to either
- check on block generation if the popup section is actually used before generating the wrapper?
- test on close button injection, if the popup section actually has elements inside?
Thanks for considering!
Comments
Comment #1
Stolzenhain CreditAttribution: Stolzenhain commentedComment #2
jdanthinne CreditAttribution: jdanthinne commentedHi, I've just pushed changes to DEV version : http://drupalcode.org/project/custom_search.git/commit/dcff123
No markup should be generated if the popup is empty.
Please test and tell me if it's ok.
Comment #3
Stolzenhain CreditAttribution: Stolzenhain commentedHello! The popup wrapper has vanished in the .dev version , so I'm marking this as fixed. Thanks!