Correct me if I'm wrong, but it appears that on line 1351:

if (!isset($_players_format)) {

should read

if (!isset($_player_format)) {

without the 's' on $_player(s)_format.

With the way it is now, line 1352:

list($_player_name, $_player_format) = _audio_player_build_list();

would always get called, so having the static variables isn't really doing much good here.

Not a big deal, but worth mentioning.

CommentFileSizeAuthor
#3 audio_195946.patch675 bytesdrewish
#2 audio_195946.patch675 bytesdrewish

Comments

drewish’s picture

mind rolling a patch?

drewish’s picture

Version: 5.x-1.3 » 5.x-1.x-dev
Status: Active » Fixed
StatusFileSize
new675 bytes

committing the attached to DRUPAL-5 and HEAD.

drewish’s picture

StatusFileSize
new675 bytes

committing the attached to DRUPAL-5 and HEAD.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.