Voting starts in March for the Drupal Association Board election.
I just wanted to report a small/minor issue related with the install file of the module.
Upon uninstall, it seems module is not deleting the
block_node_type database records related with menu_block.
Basically, we would need to add in
menu_block_uninstall (menu_block.install line 10), another call to
As a side note, I would assume perhaps a reason why this wouldn't have already been implemented would be because
menu_block_uninstall would be a direct port from the 6.x-2.x branch, and since the
block_node_type was only added in drupal-7.x, it didn't exist for the 6.x version.
Additionally, I would like to suggest replacing all the calls to variable_del, with a single
db_delete with a
'menu_block_% wildcard for the field in the condition.
I guess this change could also be applied to the 6.x-2.x branch, see menu_block.install.
I would greatly appreciate to have your feedback on this task, and if you could let me know if I overlooked or missed anything in module's implementation, or the Drupal API in general.
Feel free to let me know if you would have any questions, comments or concerns on any aspects of the discussed issues, I would be glad to explain in more details.
Thanks very much to all, in advance, for your comments, feedback, and reporting.