Title says it all. The location email field isn't big enough for some emails. Granted, there may be no limit everyone is happy with, but 31 characters seems arbitrary and low.

Files: 
CommentFileSizeAuthor
#8 location-Removed_arbitrary_maxlength_on_email-1958476-8.patch616 bytescbeier
PASSED: [[SimpleTest]]: [MySQL] 425 pass(es). View
#5 location-Removed_arbitrary_maxlength_on_email-1958476-5.patch584 bytesredijedi
PASSED: [[SimpleTest]]: [MySQL] 425 pass(es). View
#1 location-email-1958476-1_0_0.patch530 bytesredijedi
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch location-email-1958476-1_0_0.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

redijedi’s picture

FileSize
530 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch location-email-1958476-1_0_0.patch. Unable to apply patch. See the log in the details link for more information. View
podarok’s picture

Version: 7.x-3.0-alpha8 » 7.x-3.x-dev
Status: Active » Needs review

bot?

Status: Needs review » Needs work

The last submitted patch, location-email-1958476-1_0_0.patch, failed testing.

podarok’s picture

You should provide patch in git diff format
http://drupal.org/patch

redijedi’s picture

FileSize
584 bytes
PASSED: [[SimpleTest]]: [MySQL] 425 pass(es). View
podarok’s picture

Status: Needs work » Needs review

You should bump status to needs review for bot...

rooby’s picture

Status: Needs review » Needs work

Omitting the maxlength value will make it 128 characters.

I would recommend setting it to 254 characters, because that is what the database column for this field will hold and it is also the character limit for a valid email address.

cbeier’s picture

Status: Needs work » Needs review
FileSize
616 bytes
PASSED: [[SimpleTest]]: [MySQL] 425 pass(es). View

The maxlength is set to 254 characters.

podarok’s picture

Status: Needs review » Fixed

#8 commited pushed to 7.x-3.x
thanks!!!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.