Working on creating a blog in Drupal 8 and I wanted to be able to use this module so I ported it :)

Patch attached is based on 7.x-1.x branch... it's also in a sandbox http://drupal.org/sandbox/alexpott/1957810

This will have to undergo quite a lot of change once #1868772: Convert filters to plugins lands

Files: 
CommentFileSizeAuthor
#10 codefilter-port_to_drupal8-1957816-10.patch24.4 KBwesleydv
PASSED: [[SimpleTest]]: [MySQL] 2 pass(es). View
#8 codefilter-port_to_drupal8-1957816-8.patch14.91 KBwesleydv
FAILED: [[SimpleTest]]: [MySQL] 0 pass(es), 2 fail(s), and 0 exception(s). View
#5 codefilter-port_to_drupal8-1957816-5.patch14.78 KBwesleydv
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details.. View
#3 codefilter-port_to_drupal8-1957816-3.patch4.64 KBwesleydv
FAILED: [[SimpleTest]]: [MySQL] 1 pass(es), 1 fail(s), and 0 exception(s). View
codefilter-upgrade-to-d8.patch4.31 KBalexpott

Comments

Cameron Tod’s picture

Status: Active » Fixed

This is awesome, thanks so much!

I'm back from holiday now, so this is committed. I'll add a release node - let me know if you'd like me to add you to maintainers.

Automatically closed -- issue fixed for 2 weeks with no activity.

wesleydv’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
Issue summary: View changes
Status: Closed (fixed) » Needs review
FileSize
4.64 KB
FAILED: [[SimpleTest]]: [MySQL] 1 pass(es), 1 fail(s), and 0 exception(s). View

#1868772: Convert filters to plugins has landed so the original patch of Alex is outdated.

Attached a new patch, still needs some work but basic functionality works.

Status: Needs review » Needs work

The last submitted patch, 3: codefilter-port_to_drupal8-1957816-3.patch, failed testing.

wesleydv’s picture

Status: Needs work » Needs review
FileSize
14.78 KB
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details.. View

Fixed failing Unit test

Cameron Tod’s picture

Awesome, thanks man. I will apply and push this if the test comes back green.

Status: Needs review » Needs work

The last submitted patch, 5: codefilter-port_to_drupal8-1957816-5.patch, failed testing.

wesleydv’s picture

Status: Needs work » Needs review
FileSize
14.91 KB
FAILED: [[SimpleTest]]: [MySQL] 0 pass(es), 2 fail(s), and 0 exception(s). View

Lets try that again :)

Status: Needs review » Needs work

The last submitted patch, 8: codefilter-port_to_drupal8-1957816-8.patch, failed testing.

wesleydv’s picture

Status: Needs work » Needs review
FileSize
24.4 KB
PASSED: [[SimpleTest]]: [MySQL] 2 pass(es). View

A quick fix clearly does not work :)
I did a proper fix/rewrite now moving all functions to the CodeFilter class.
Still todo: Write more/better unit tests.

Cameron Tod’s picture

Status: Needs review » Fixed

Thanks! This is committed with attribution: http://drupalcode.org/project/codefilter.git/commit/187289666fb7573f3f7e...

If you write more unit tests or want to do further conversion, can you open a new issue? I'll close this one off.

Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.