Using the Bartik theme If you add a custom block to the featured region and make it only appear on the front page - an empty region is still showing on other pages.

The front page

00.png

Another page

00.png

Files: 
CommentFileSizeAuthor
#4 1957104.empty-region.4.test-only-will-fail.patch569 bytesalexpott
FAILED: [[SimpleTest]]: [MySQL] 53,717 pass(es), 1 fail(s), and 0 exception(s). View
#4 1957104.empty-region.4.patch1.32 KBalexpott
PASSED: [[SimpleTest]]: [MySQL] 54,166 pass(es). View
#1 Snapshot 30:03:2013 19:17.png38.96 KBalexpott
#1 1957104.empty-region.1.patch782 bytesalexpott
PASSED: [[SimpleTest]]: [MySQL] 53,628 pass(es). View
Screenshot 30:03:2013 19:00.png66.16 KBalexpott
Snapshot 30:03:2013 19:00.png41.98 KBalexpott

Comments

alexpott’s picture

FileSize
782 bytes
PASSED: [[SimpleTest]]: [MySQL] 53,628 pass(es). View
38.96 KB

Aha... contextual links are being added to the array returned by _block_get_renderable_region() even if the block itself was not!

With the patch attached my blog page looks as it should

17.png

alexpott’s picture

Status: Active » Needs review
tim.plunkett’s picture

Issue tags: +Needs tests

Nice find! This should be pretty straightforward to test.

alexpott’s picture

Issue tags: -Needs tests
FileSize
1.32 KB
PASSED: [[SimpleTest]]: [MySQL] 54,166 pass(es). View
569 bytes
FAILED: [[SimpleTest]]: [MySQL] 53,717 pass(es), 1 fail(s), and 0 exception(s). View

Test added :)

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Awesome! Green if it's green.

xjm’s picture

#4: 1957104.empty-region.4.patch queued for re-testing.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Good one!

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.