Problem/Motivation

Nowadays many locations such as shops, companies even monuments has own webpage so in my opinion it should be possible by default to provide webadress for such location.

TODO:
Web adress validation.

Files: 
CommentFileSizeAuthor
#7 Location_www_1954248_5.patch7.12 KBYuriy Krysiuk
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch Location_www_1954248_5.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#4 Location_www_1954248_4.patch7.37 KBYuriy Krysiuk
PASSED: [[SimpleTest]]: [MySQL] 425 pass(es).
[ View ]
location_www.zip2.88 KBmist

Comments

podarok’s picture

Status:Active» Needs work

You should provide a code in git diff format
http://drupal.org/patch
Goof to see here a tests (look at /tests folder for examples)

mist’s picture

Sorry for that but at this moment I am unfamiliar with git. If you could help me with this it would be great.

Yuriy Krysiuk’s picture

Assigned:Unassigned» Yuriy Krysiuk
Issue summary:View changes
Yuriy Krysiuk’s picture

Status:Needs work» Needs review
StatusFileSize
new7.37 KB
PASSED: [[SimpleTest]]: [MySQL] 425 pass(es).
[ View ]

Created patch file

moymilo’s picture

Assigned:Yuriy Krysiuk» Unassigned
podarok’s picture

Status:Needs review» Needs work
  1. +++ b/location_www.info
    @@ -0,0 +1,16 @@
    +files[] = location_www.module

    There are no classes within a file. Let's do not overload autoloader

  2. +++ b/location_www.info
    @@ -0,0 +1,16 @@
    +files[] = location_www.install

    The same

  3. +++ b/location_www.info
    @@ -0,0 +1,16 @@
    +; Information added by drupal.org packaging script on 2012-07-25
    +version = "7.x-3.0-alpha1"
    +core = "7.x"
    +project = "location"
    +datestamp = "1343220794"

    No needs to add this, because it will be added by drupal.org automatically. Let's get rid of it

Yuriy Krysiuk’s picture

StatusFileSize
new7.12 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch Location_www_1954248_5.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Added new patch file

Yuriy Krysiuk’s picture

Status:Needs work» Needs review
podarok’s picture

Status:Needs review» Fixed

Thanks, commited

  • podarok committed 97f3a31 on 7.x-3.x authored by mist
    Issue #1954248 by Yuriy Krysiuk, mist: Location WWW contrib module
    

Status:Fixed» Needs work

The last submitted patch, 7: Location_www_1954248_5.patch, failed testing.