Follow up from
Changes to happen
Talked this through a little with alexpott on IRC and moving the logic to the storage controllers is a good idea. He suggested making the methods also static and renaming the method to findByProperties() but that's more of a config overall DX issue that needs to created.
So for now, just moving the logic and not yet deprecating the old functions is enough for this patch.
Move to EFQ ? are they even still needed ?.
Probably involves a separate API to retrieve deleted fields, which very little code actually needs to deal with.
PASSED: [[SimpleTest]]: [MySQL] 55,517 pass(es).
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch interdiff-19vs22.patch. Unable to apply patch. See the log in the details link for more information.
PASSED: [[SimpleTest]]: [MySQL] 55,297 pass(es).