We only look for failures but not errors. The first error is fatal btw, notice or not. I am not sure on how to write a test for this.

CommentFileSizeAuthor
#5 1949266-tests-only-1.patch4.49 KBno_commit_credit
#5 1949266_1.patch6 KBno_commit_credit
#2 1949266_1.patch6 KBchx
phpunit_error.patch1.16 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Priority: Normal » Major

This is pretty serious.

chx’s picture

chx CreditAttribution: chx commented
Priority: Major » Normal
FileSize
1949266_1.patch6 KB

Here's a test, mostly written by msonnabaum. Don't forget to credit him. Also, I added an additional safeguard for the case of 'No tests were ran'.

chx’s picture

chx CreditAttribution: chx commented
Priority: Normal » Major

xpost.

msonnabaum’s picture

msonnabaum CreditAttribution: msonnabaum commented
Status: Needs review » Reviewed & tested by the community

Looks good to me if testbot comes back ok.

no_commit_credit’s picture

no_commit_credit CreditAttribution: no_commit_credit commented
FileSize
1949266_1.patch6 KB
1949266-tests-only-1.patch4.49 KB

Test-only patch to (presumably) expose the coverage.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

#5: 1949266_1.patch queued for re-testing.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Issue tags: +Quick fix
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.